Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error format and bump minor version #8

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Fix error format and bump minor version #8

merged 1 commit into from
Nov 20, 2018

Conversation

brunobar79
Copy link
Contributor

Promise rejections were not using errors. That causes a lot of [object Object] in the UI and notifications.

This PR fixes that.

@brunobar79 brunobar79 changed the title Fix error format and bump Fix error format and bump version Nov 20, 2018
@brunobar79 brunobar79 changed the title Fix error format and bump version Fix error format and bump minor version Nov 20, 2018
@brunobar79
Copy link
Contributor Author

@bitpshr Thanks for the review!

@brunobar79 brunobar79 merged commit 8788c83 into master Nov 20, 2018
@whymarrh whymarrh deleted the fix-errors branch February 24, 2020 20:40
julianariel referenced this pull request in block-wallet/eth-ledger-bridge-keyring Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants