Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/libs update #8

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Chore/libs update #8

merged 2 commits into from
Mar 13, 2023

Conversation

chk0912
Copy link

@chk0912 chk0912 commented Jan 3, 2023 •
edited
Loading

Implementing the last versions of the EthereumJS libraries.

needed for: block-wallet/extension#318

@chk0912 chk0912 changed the title new ethereumjs libs versions Chore/libs update Jan 3, 2023
@chk0912 chk0912 requested a review from a team January 3, 2023 15:32
@chk0912 chk0912 mentioned this pull request Jan 3, 2023
Closed
@sreblock
Copy link

sreblock commented Jan 3, 2023

We have an automation that creates a PR here when there are new features here https://github.com/MetaMask/eth-ledger-bridge-keyring. This PR will cause conflicts in the future (specially for the package.json and yarn.lock files) so we'll have to solve them manually.

@chk0912 chk0912 mentioned this pull request Feb 17, 2023
Merged
@fpezzola
Copy link

We have an automation that creates a PR here when there are new features here https://github.com/MetaMask/eth-ledger-bridge-keyring. This PR will cause conflicts in the future (specially for the package.json and yarn.lock files) so we'll have to solve them manually.

What are we going to do with this PR?

@chk0912
Copy link
Author

chk0912 commented Feb 23, 2023

We have an automation that creates a PR here when there are new features here https://github.com/MetaMask/eth-ledger-bridge-keyring. This PR will cause conflicts in the future (specially for the package.json and yarn.lock files) so we'll have to solve them manually.

What are we going to do with this PR?

What we agreed yesterday is:

Once the keystone PR is ready to be merged, we are going to merge this PR and the Trezor PR. Then we are going to generate a semver tag for each repo and update the npm package references in the extension. Finally, we merge the keystone PR.

@chk0912 chk0912 merged commit 2152741 into main Mar 13, 2023
@chk0912 chk0912 deleted the chore/libs-update branch March 13, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianariel julianariel julianariel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chk0912 @sreblock @fpezzola @julianariel