Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all TypeScript rules, remove deprecated rules #27

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Update all TypeScript rules, remove deprecated rules #27

merged 1 commit into from
Feb 20, 2020

Conversation

whymarrh
Copy link
Contributor

@whymarrh whymarrh commented Feb 20, 2020 •
edited
Loading

Refs #12

This PR updates our TS config, in response to comments on #25. I've removed any rules not listed under Supported Rules at v2.20.0.

Also refs #2—this PR explicitly disables all of those rules.

@whymarrh whymarrh requested review from Gudahtt and rekmarks February 20, 2020 19:50
This was referenced Feb 20, 2020
Merged
Merged
Gudahtt
Gudahtt approved these changes Feb 20, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@whymarrh whymarrh merged commit b7e641a into master Feb 20, 2020
@whymarrh whymarrh deleted the updated-ts-rules branch February 20, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@rekmarks rekmarks Awaiting requested review from rekmarks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whymarrh @Gudahtt