Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.0 #26

Merged
merged 3 commits into from
Feb 21, 2020
Merged

v2.0.0 #26

merged 3 commits into from
Feb 21, 2020

Conversation

whymarrh
Copy link
Contributor

This PR represents the v2.0.0 release.

@whymarrh whymarrh requested review from Gudahtt and rekmarks February 20, 2020 18:00
rekmarks
rekmarks previously approved these changes Feb 20, 2020
@Gudahtt
Copy link
Member

Gudahtt commented Feb 20, 2020

FYI I had a bit more feedback on the TypeScript rules - might want to hold off on this release until those are updated

@whymarrh
Copy link
Contributor Author

FYI I had a bit more feedback on the TypeScript rules - might want to hold off on this release until those are updated

Where is this feedback?

@Gudahtt
Copy link
Member

Gudahtt commented Feb 20, 2020

It's in a draft review - I'm not finished yet. The tl;dr is that a bunch of the typescript rules you added are deprecated.

@whymarrh
Copy link
Contributor Author

See #27, I've updated the TS rules

@whymarrh whymarrh merged commit 33636f5 into master Feb 21, 2020
@whymarrh whymarrh deleted the v2 branch February 21, 2020 13:31
@whymarrh whymarrh mentioned this pull request Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants