Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change naming of provider to providerConfig where applicable #995

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Change naming of provider to providerConfig where applicable #995

merged 1 commit into from
Dec 1, 2022

Conversation

BelfordZ
Copy link
Contributor

fixes #994

@BelfordZ BelfordZ requested a review from a team as a code owner November 30, 2022 20:45
@BelfordZ BelfordZ force-pushed the fix/network-provider-config-naming branch from 835ace5 to ec4f520 Compare November 30, 2022 20:55
mcmire
mcmire approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me! I appreciate the small commit.

legobeat
legobeat approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big readability improvement - would be great to see this naming normalized across repos over time.

@BelfordZ BelfordZ merged commit 55c30e2 into main Dec 1, 2022
@BelfordZ BelfordZ deleted the fix/network-provider-config-naming branch December 1, 2022 18:58
gantunesr pushed a commit that referenced this pull request Dec 8, 2022
@BelfordZ @gantunesr
Change naming of provider to providerConfig where applicable (#995)
f340ebb 
fixes #994
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@BelfordZ @MajorLift
Change naming of provider to providerConfig where applicable (#995)
e577f3d 
fixes #994
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@BelfordZ @MajorLift
Change naming of provider to providerConfig where applicable (#995)
defb77b 
fixes #994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legobeat legobeat legobeat approved these changes

@mcmire mcmire mcmire approved these changes

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

@adonesky1 adonesky1 Awaiting requested review from adonesky1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the naming of NetworkController.state.provider -> providerConfig
3 participants
@BelfordZ @mcmire @legobeat