Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the naming of NetworkController.state.provider -> providerConfig #994

Closed
BelfordZ opened this issue Nov 30, 2022 · 0 comments · Fixed by #995
Closed

Fix the naming of NetworkController.state.provider -> providerConfig #994

BelfordZ opened this issue Nov 30, 2022 · 0 comments · Fixed by #995
Assignees
@BelfordZ

Comments

@BelfordZ
Copy link
Contributor

The network controller has code which makes ambiguous use of the name provider. In cases where it really is refering to an instance of the ProviderConfig type, it should be named providerConfig (or really anything other than calling the config provider).
BelfordZ added a commit that referenced this issue Nov 30, 2022
@BelfordZ
Change naming of provider to providerConfig where applicable
835ace5 
fixes #994
@BelfordZ BelfordZ mentioned this issue Nov 30, 2022
Merged
BelfordZ added a commit that referenced this issue Nov 30, 2022
@BelfordZ
Change naming of provider to providerConfig where applicable
ec4f520 
fixes #994
@BelfordZ BelfordZ self-assigned this Nov 30, 2022
BelfordZ added a commit that referenced this issue Dec 1, 2022
@BelfordZ
Change naming of provider to providerConfig where applicable (#995)
55c30e2 
fixes #994
gantunesr pushed a commit that referenced this issue Dec 8, 2022
@BelfordZ @gantunesr
Change naming of provider to providerConfig where applicable (#995)
f340ebb 
fixes #994
MajorLift pushed a commit that referenced this issue Oct 11, 2023
@BelfordZ @MajorLift
Change naming of provider to providerConfig where applicable (#995)
e577f3d 
fixes #994
MajorLift pushed a commit that referenced this issue Oct 11, 2023
@BelfordZ @MajorLift
Change naming of provider to providerConfig where applicable (#995)
defb77b 
fixes #994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BelfordZ BelfordZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change naming of provider to providerConfig where applicable MetaMask/core
1 participant
@BelfordZ