Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set balanc3 autoconversion off #53

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Conversation

estebanmino
Copy link
Contributor

As explained here MetaMask/metamask-extension#6005, for some tokens balanc2 returns the usd conversion not the native currency being asked.

@codecov-io
Copy link

codecov-io commented Jan 15, 2019

Codecov Report

Merging #53 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #53   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          20     20           
  Lines        1014   1014           
  Branches      113    113           
=====================================
  Hits         1014   1014
Impacted Files Coverage Δ
src/TokenRatesController.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75ccc4a...84c7a1f. Read the comment docs.

@brunobar79 brunobar79 self-requested a review January 15, 2019 23:43
Copy link
Contributor

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@estebanmino estebanmino merged commit 865a5de into master Jan 15, 2019
@estebanmino estebanmino deleted the balanc3-autoconversion branch January 15, 2019 23:47
mcmire pushed a commit to mcmire/core that referenced this pull request Jul 17, 2023
* 3.3.1

* Updated changelog

* Better changelog name

* Even nicer CHANGELOG message

Co-authored-by: github-actions <[email protected]>
Co-authored-by: Olaf Tomalka <[email protected]>
kanthesha pushed a commit that referenced this pull request Sep 19, 2023
kanthesha pushed a commit that referenced this pull request Oct 11, 2023
* remove babel, build scripts; update lint parser

* use ecmaVersion 2017, disable spread rule
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
MajorLift pushed a commit that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants