Remove babel (#53)

* remove babel, build scripts; update lint parser * use ecmaVersion 2017, disable spread rule
MetaMask · Jul 27, 2020 · 993dda8 · 993dda8
1 parent fab806e
commit 993dda8
Show file tree

Hide file tree

Showing 5 changed files with 32 additions and 1,633 deletions.
diff --git a/merged-packages/json-rpc-engine/.eslintrc.js b/merged-packages/json-rpc-engine/.eslintrc.js
@@ -1,29 +1,25 @@
 module.exports = {
   root: true,
 
-  extends: [
-    '@metamask/eslint-config',
-    '@metamask/eslint-config/config/mocha',
-    '@metamask/eslint-config/config/nodejs',
-  ],
-
-  parser: 'babel-eslint',
-
   parserOptions: {
     ecmaVersion: 2017,
-    ecmaFeatures: {
-      arrowFunctions: true,
-      classes: true,
-      experimentalObjectRestSpread: true,
-    },
   },
 
   plugins: [
-    'babel',
     'json',
     'import',
   ],
 
+  extends: [
+    '@metamask/eslint-config',
+    '@metamask/eslint-config/config/mocha',
+    '@metamask/eslint-config/config/nodejs',
+  ],
+
+  rules: {
+    'prefer-object-spread': 'off',
+  },
+
   overrides: [{
     files: [
       '.eslintrc.js',
@@ -32,6 +28,4 @@ module.exports = {
       sourceType: 'script',
     },
   }],
-
-  ignorePatterns: ['dist'],
 }
diff --git a/merged-packages/json-rpc-engine/package.json b/merged-packages/json-rpc-engine/package.json
@@ -12,7 +12,6 @@
   "scripts": {
     "lint": "eslint . --ext js,json",
     "lint:fix": "eslint . --ext js,json --fix",
-    "build": "babel src --out-dir dist",
     "test": "mocha ./test",
     "coverage": "nyc yarn test"
   },
@@ -22,16 +21,8 @@
     "safe-event-emitter": "^1.0.1"
   },
   "devDependencies": {
-    "@babel/cli": "^7.8.4",
-    "@babel/core": "^7.8.6",
-    "@babel/plugin-transform-runtime": "^7.8.3",
-    "@babel/preset-env": "^7.8.6",
-    "@babel/runtime": "^7.8.4",
     "@metamask/eslint-config": "^2.1.0",
-    "babel-eslint": "^10.1.0",
-    "babelify": "^10.0.0",
     "eslint": "^6.8.0",
-    "eslint-plugin-babel": "^5.3.0",
     "eslint-plugin-import": "^2.20.1",
     "eslint-plugin-json": "^2.1.0",
     "eslint-plugin-mocha": "^6.3.0",

diff --git a/merged-packages/json-rpc-engine/src/index.js b/merged-packages/json-rpc-engine/src/index.js
@@ -65,7 +65,7 @@ module.exports = class RpcEngine extends SafeEventEmitter {
 
   _handle (_req, cb) {
 
-    const req = { ..._req }
+    const req = Object.assign({}, _req)
     const res = {
       id: req.id,
       jsonrpc: req.jsonrpc,

diff --git a/merged-packages/json-rpc-engine/test/idRemapMiddleware.spec.js b/merged-packages/json-rpc-engine/test/idRemapMiddleware.spec.js
@@ -29,7 +29,7 @@ describe('idRemapMiddleware tests', function () {
     })
 
     const payload = { id: 1, jsonrpc: '2.0', method: 'hello' }
-    const payloadCopy = { ...payload }
+    const payloadCopy = Object.assign({}, payload)
 
     engine.handle(payload, function (err, res) {
       assert.ifError(err, 'did not error')