Extract CryptoCompare API #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
extract-crypto-compare-API
branch
2 times, most recently
from
5a4bb93 to
1c8f150
Compare
Gudahtt
force-pushed
the
extract-crypto-compare-API
branch
2 times, most recently
from
2c2b75c to
4fdfa96
Compare
The CryptoCompare API interactions have been extracted from the CurrencyRateController and moved into a separate module.
Gudahtt
force-pushed
the
extract-crypto-compare-API
branch
from
c8959f7 to
263ba76
Compare
10 tasks
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The CryptoCompare API interactions have been extracted from the CurrencyRateController and moved into a separate module.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The CryptoCompare API interactions have been extracted from the CurrencyRateController and moved into a separate module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CryptoCompare API interactions have been extracted from the CurrencyRateController and moved into a separate module.
This is part of #337. The API interactions have been extracted to simplify the controller, and make it easier to thoroughly test the API interactions and the controller logic.