Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate API interactions from controllers to API modules #430

Open
1 of 10 tasks
Gudahtt opened this issue Mar 24, 2021 · 0 comments
Open
1 of 10 tasks

Migrate API interactions from controllers to API modules #430

Gudahtt opened this issue Mar 24, 2021 · 0 comments
Labels
enhancement New feature or request team-wallet-framework

Comments

@Gudahtt
Copy link
Member

Gudahtt commented Mar 24, 2021 •
edited
Loading

As part of the controller API redesign, we will be migrating API interactions in controllers to separate modules, to simplify our controllers. This is a tracking issue for migrating each of those API interactions.

  • Fiat exchange rates from CryptoCompare (CurrencyRateController) - Completed in Extract CryptoCompare API #353
  • Token exchange rates from CoinGecko (TokenRatesController) (Migrate GoinGecko API interactions to separate module #625 )
  • Token/NFT balance checking (AssetsContractController)
  • JSDelivr phishing configuration (PhishingController)
  • Etherscan account transaction history (TransactionController via util.js)
  • EthQuery (AccountTrackerController)
  • EthQuery (TransactionController)
  • EthQuery (NetworkController)
  • Collectible/Token Detection (AssetsDetectionController)
  • Ethers/Token Contract/Interace Support Check (TokensController)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@desi @Gudahtt @astarinmymind