Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate GoinGecko API interactions to separate module #625

Closed
Gudahtt opened this issue Nov 4, 2021 · 3 comments
Closed

Migrate GoinGecko API interactions to separate module #625

Gudahtt opened this issue Nov 4, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers team-wallet-framework

Comments

@Gudahtt
Copy link
Member

Gudahtt commented Nov 4, 2021

Our usage of CoinGecko should be extracted from the TokenRatesController and made into its own module. This module should be responsible for correctly formatting the request, and parsing the response and returning it in a sensible format.

This module should also handle any necessary validation, ensuring that an error is thrown if we don't get the information we want.

It should also be fully tested. And since it's no longer part of the TokenRatesController, we should remove any API-focused tests from the TokenRatesController test suite, and mock this new API module there instead of using network mocks.

@Gudahtt Gudahtt added enhancement New feature or request good first issue Good for newcomers labels Nov 4, 2021
@Gudahtt Gudahtt changed the title Migrate GoinGecko APi interactions to separate module Migrate GoinGecko API interactions to separate module Mar 10, 2022
@akp111
Copy link

akp111 commented Jul 30, 2023

Hey @Gudahtt , is it still a requirement? I would love to take it up

@mcmire
Copy link
Contributor

mcmire commented Mar 18, 2024

@Gudahtt Is this effectively complete now, or is there anything missing with the current token service pattern that we still want to address?

@Gudahtt
Copy link
Member Author

Gudahtt commented Mar 18, 2024

This was completed in #3600

@Gudahtt Gudahtt closed this as completed Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers team-wallet-framework
Projects
None yet
Development

No branches or pull requests

4 participants