Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary babel-runtime dependencies #1504

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Remove unnecessary babel-runtime dependencies #1504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f99d12
Remove unnecessary `babel-runtime` dependencies
Gudahtt Jul 14, 2023
91820c3
Move `babel-runtime` to `peerDependencies`
Gudahtt Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions constraints.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,16 @@ gen_enforced_field(WorkspaceCwd, 'publishConfig.registry', 'https://registry.npm
gen_enforced_field(WorkspaceCwd, 'publishConfig', null) :-
workspace_field(WorkspaceCwd, 'private', true).

% eth-query has an unlisted dependency on babel-runtime, so that package needs
% to be present if eth-query is present.
gen_enforced_dependency(WorkspaceCwd, 'babel-runtime', '^6.26.0', DependencyType) :-
workspace_has_dependency(WorkspaceCwd, 'eth-query', _, DependencyType).
% nonce-tracker has an unlisted dependency on babel-runtime (via `ethjs-query`), so that package
% needs to be present if nonce-tracker is present.
gen_enforced_dependency(WorkspaceCwd, 'babel-runtime', '^6.26.0', 'peerDependencies') :-
workspace_has_dependency(WorkspaceCwd, 'nonce-tracker', _, 'dependencies').
gen_enforced_dependency(WorkspaceCwd, 'babel-runtime', '^6.26.0', 'devDependencies') :-
workspace_has_dependency(WorkspaceCwd, 'nonce-tracker', _, 'dependencies').

% eth-method-registry has an unlisted dependency on babel-runtime (via `ethjs->ethjs-query`), so
% that package needs to be present if eth-method-registry is present.
gen_enforced_dependency(WorkspaceCwd, 'babel-runtime', '^6.26.0', 'peerDependencies') :-
workspace_has_dependency(WorkspaceCwd, 'eth-method-registry', _, 'dependencies').
gen_enforced_dependency(WorkspaceCwd, 'babel-runtime', '^6.26.0', 'devDependencies') :-
workspace_has_dependency(WorkspaceCwd, 'eth-method-registry', _, 'dependencies').
1 change: 0 additions & 1 deletion packages/assets-controllers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
"@types/uuid": "^8.3.0",
"abort-controller": "^3.0.0",
"async-mutex": "^0.2.6",
"babel-runtime": "^6.26.0",
"eth-query": "^2.1.2",
"ethereumjs-util": "^7.0.10",
"immer": "^9.0.6",
Expand Down
1 change: 0 additions & 1 deletion packages/controller-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
"dependencies": {
"@metamask/utils": "^5.0.2",
"@spruceid/siwe-parser": "1.1.3",
"babel-runtime": "^6.26.0",
"eth-ens-namehash": "^2.0.8",
"eth-query": "^2.1.2",
"eth-rpc-errors": "^4.0.2",
Expand Down
1 change: 0 additions & 1 deletion packages/gas-fee-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
"@metamask/network-controller": "workspace:^",
"@metamask/utils": "^5.0.2",
"@types/uuid": "^8.3.0",
"babel-runtime": "^6.26.0",
"eth-query": "^2.1.2",
"ethereumjs-util": "^7.0.10",
"ethjs-unit": "^0.1.6",
Expand Down
1 change: 0 additions & 1 deletion packages/network-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
"@metamask/swappable-obj-proxy": "^2.1.0",
"@metamask/utils": "^5.0.2",
"async-mutex": "^0.2.6",
"babel-runtime": "^6.26.0",
"eth-block-tracker": "^7.0.1",
"eth-query": "^2.1.2",
"eth-rpc-errors": "^4.0.2",
Expand Down
5 changes: 3 additions & 2 deletions packages/transaction-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
"@metamask/network-controller": "workspace:^",
"@metamask/utils": "^5.0.2",
"async-mutex": "^0.2.6",
"babel-runtime": "^6.26.0",
"eth-method-registry": "1.1.0",
"eth-query": "^2.1.2",
"eth-rpc-errors": "^4.0.2",
Expand All @@ -49,6 +48,7 @@
"@metamask/auto-changelog": "^3.1.0",
"@types/jest": "^27.4.1",
"@types/node": "^16.18.24",
"babel-runtime": "^6.26.0",
"deepmerge": "^4.2.2",
"ethjs-provider-http": "^0.1.6",
"jest": "^27.5.1",
Expand All @@ -60,7 +60,8 @@
},
"peerDependencies": {
"@metamask/approval-controller": "workspace:^",
"@metamask/network-controller": "workspace:^"
"@metamask/network-controller": "workspace:^",
"babel-runtime": "^6.26.0"
},
"engines": {
"node": ">=16.0.0"
Expand Down
5 changes: 1 addition & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1324,7 +1324,6 @@ __metadata:
"@types/uuid": ^8.3.0
abort-controller: ^3.0.0
async-mutex: ^0.2.6
babel-runtime: ^6.26.0
deepmerge: ^4.2.2
eth-query: ^2.1.2
ethereumjs-util: ^7.0.10
Expand Down Expand Up @@ -1422,7 +1421,6 @@ __metadata:
"@spruceid/siwe-parser": 1.1.3
"@types/jest": ^27.4.1
abort-controller: ^3.0.0
babel-runtime: ^6.26.0
deepmerge: ^4.2.2
eth-ens-namehash: ^2.0.8
eth-query: ^2.1.2
Expand Down Expand Up @@ -1699,7 +1697,6 @@ __metadata:
"@types/jest": ^27.4.1
"@types/jest-when": ^2.7.3
"@types/uuid": ^8.3.0
babel-runtime: ^6.26.0
deepmerge: ^4.2.2
eth-query: ^2.1.2
ethereumjs-util: ^7.0.10
Expand Down Expand Up @@ -1818,7 +1815,6 @@ __metadata:
"@types/jest-when": ^2.7.3
"@types/lodash": ^4.14.191
async-mutex: ^0.2.6
babel-runtime: ^6.26.0
deepmerge: ^4.2.2
eth-block-tracker: ^7.0.1
eth-query: ^2.1.2
Expand Down Expand Up @@ -2051,6 +2047,7 @@ __metadata:
peerDependencies:
"@metamask/approval-controller": "workspace:^"
"@metamask/network-controller": "workspace:^"
babel-runtime: ^6.26.0
languageName: unknown
linkType: soft

Expand Down