Remove unnecessary babel-runtime dependencies
#1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
What do you think about additionally moving the remaining |
|
Great idea! Done in 2320069 |
We included `babel-runtime` as a dependency to a few packages because we thought it was an undocumented dependency of `eth-query`, but we had gotten it mixed up with `ethjs-query`. Really we only need this as a dependency in the transaction controller. The constraints have been updated, and all unnecessary references to `babel-runtime` have been removed.
Gudahtt
force-pushed
the
remove-unnecessary-babel-runtime-dependencies
branch
from
2320069 to
91820c3
Compare
legobeat
approved these changes
Jul 14, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Remove unnecessary `babel-runtime` dependencies We included `babel-runtime` as a dependency to a few packages because we thought it was an undocumented dependency of `eth-query`, but we had gotten it mixed up with `ethjs-query`. Really we only need this as a dependency in the transaction controller. The constraints have been updated, and all unnecessary references to `babel-runtime` have been removed. * Move `babel-runtime` to `peerDependencies`
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Remove unnecessary `babel-runtime` dependencies We included `babel-runtime` as a dependency to a few packages because we thought it was an undocumented dependency of `eth-query`, but we had gotten it mixed up with `ethjs-query`. Really we only need this as a dependency in the transaction controller. The constraints have been updated, and all unnecessary references to `babel-runtime` have been removed. * Move `babel-runtime` to `peerDependencies`
Merged
13 tasks
tommasini
added a commit
that referenced
this pull request
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
We included
babel-runtimeas a dependency to a few packages because we thought it was an undocumented dependency ofeth-query, but we had gotten it mixed up withethjs-query. Really we only need this as a dependency in the transaction controller.The constraints have been updated, and all unnecessary references to
babel-runtimehave been removed.Additionally, in the one package where it's still required,
babel-runtimehas been made into apeerDependencyinstead of a direct dependency. This better reflects the requirement: we don't need to use it directly, we just need it to be available in the environment this package is run in.References
The missing
babel-runtimedependency was discovered in #341Changelog
@metamask/assets-controllersbabel-runtimedependency@metamask/controller-utilsbabel-runtimedependency@metamask/network-controllerbabel-runtimedependency@metamask/transaction-controllerbabel-runtimefrom adependencyto apeerDependencyChecklist