NetworkController: Fix chain IDs in tests #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we replace `web3-provider-engine`, we will intercept `eth_chainId` to return a static result, which, for custom RPC endpoints, will come from the chain ID in the provider config. This means that this chain ID must be convertable to a 0x-prefixed hex string. However, when we specify chain IDs in the NetworkController tests, we sometimes use fake hex numbers. So this commit fixes various references in the tests to fulfill this requirement and generally make chain IDs match what we would expect them to be in reality.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
When we replace `web3-provider-engine`, we will intercept `eth_chainId` to return a static result, which, for custom RPC endpoints, will come from the chain ID in the provider config. This means that this chain ID must be convertable to a 0x-prefixed hex string. However, when we specify chain IDs in the NetworkController tests, we sometimes use fake hex numbers. So this commit fixes various references in the tests to fulfill this requirement and generally make chain IDs match what we would expect them to be in reality.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
When we replace `web3-provider-engine`, we will intercept `eth_chainId` to return a static result, which, for custom RPC endpoints, will come from the chain ID in the provider config. This means that this chain ID must be convertable to a 0x-prefixed hex string. However, when we specify chain IDs in the NetworkController tests, we sometimes use fake hex numbers. So this commit fixes various references in the tests to fulfill this requirement and generally make chain IDs match what we would expect them to be in reality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we replace
web3-provider-engine, we will intercepteth_chainIdto return a static result, which, for custom RPC endpoints, will come from the chain ID in the provider config. This means that this chain ID must be convertable to a 0x-prefixed hex string. However, when we specify chain IDs in the NetworkController tests, we sometimes use fake hex numbers. So this commit fixes various references in the tests to fulfill this requirement and generally make chain IDs match what we would expect them to be in reality.Changes
N/A
References
Reduces the scope of #1116.
Checklist