Skip to content

Commit

Permalink
NetworkController: Fix chain IDs in tests (#1307)
Browse files Browse the repository at this point in the history
When we replace `web3-provider-engine`, we will intercept `eth_chainId`
to return a static result, which, for custom RPC endpoints, will come
from the chain ID in the provider config. This means that this chain ID
must be convertable to a 0x-prefixed hex string. However, when we
specify chain IDs in the NetworkController tests, we sometimes use
fake hex numbers. So this commit fixes various references in the tests
to fulfill this requirement and generally make chain IDs match what we
would expect them to be in reality.
  • Loading branch information
mcmire authored May 2, 2023
1 parent 6ded2a3 commit dd21800
Showing 1 changed file with 62 additions and 62 deletions.
Loading

0 comments on commit dd21800

Please sign in to comment.