Skip to content
This repository has been archived by the owner on May 12, 2022. It is now read-only.

Ether-less Confirm TX Screens (Pure Function Calls) #16

Closed
cjeria opened this issue May 22, 2018 · 3 comments
Closed

Ether-less Confirm TX Screens (Pure Function Calls) #16

cjeria opened this issue May 22, 2018 · 3 comments

Comments

@cjeria
Copy link
Contributor

cjeria commented May 22, 2018

Dan commented:

Pure Function Calls

Not all transactions have ether implicitly attached to them. Often, the transaction really is about the Data. For those, the big header (about 30% of the view) would be dedicated to showing $0.00 0.0000 ether.

For cases when there is no ether being sent, and there is data associated with the transaction, and we are able to retrieve a function name from the on-chain registry, I strongly feel we should show the function name as a primary label on the confirmation screen. It is clearly the most useful information we could show the user.

@cjeria
Copy link
Contributor Author

cjeria commented May 23, 2018

Possibly detect pure function calls (etherless actions) and swap out the body components with something that makes more sense with this specific type of function call.
confirm screen - method copy

@bdresser
Copy link

bdresser commented Jun 5, 2018

as discussed today, this can probably follow the designs in #11 closely, just need to replace the $/ETH value with a text treatment of the function call or something along those lines

user will still need to pay gas & would probably like the additional stuff in the data tab.

@cjeria cjeria removed the Permissions / Pop-ups Related to user permissions and dapp-wallet actions label Apr 3, 2019
@cjeria cjeria removed their assignment Apr 3, 2019
@bdresser
Copy link

this will be handled as part of #80

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants