Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requirements gathering, architecture and code design for Confirm Screen refactor #4481

Closed
danjm opened this issue Jun 4, 2018 · 3 comments
Closed

Requirements gathering, architecture and code design for Confirm Screen refactor #4481

danjm opened this issue Jun 4, 2018 · 3 comments
Labels
area-UI Relating to the user interface. type-discussion

Comments

@danjm
Copy link
Contributor

danjm commented Jun 4, 2018 •
edited
Loading

This is a ticket for the architecture and code design for #4404

@alextsg @whymarrh
@danjm danjm added area-UI Relating to the user interface. type-discussion labels Jun 4, 2018
@danjm danjm changed the title Architecture and code design for Confirm Screen refactor Requirements gathering, architecture and code design for Confirm Screen refactor Jun 4, 2018
@danjm
Copy link
Contributor Author

danjm commented Jun 4, 2018

Requirements should include accomodatation of these designs: MetaMask/Design#18, MetaMask/Design#16

Another note on requirements: Metamask may eventually wish to support additional transaction types. For example, confirmation of multisig transactions. For different transaction types, validation of transaction data, and the method called when clicking submit, may differ. UIs for different types may differ as well, but the differences will likely be small.

@bdresser
Copy link
Contributor

bdresser commented Jun 4, 2018

@danjm are you guys moving on this shortly? if so let's chat with @cjeria tomorrow to make sure we're on the same page for the UI updates

@alextsg alextsg mentioned this issue Jul 12, 2018
Merged
@alextsg alextsg closed this as completed Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-UI Relating to the user interface. type-discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bdresser @danjm @alextsg and others