-
Notifications
You must be signed in to change notification settings - Fork 11
Assets optimization #77
base: 1.17.1
Are you sure you want to change the base?
Conversation
Lossless compression made with the Leanify tool.
I am curious why you proposed this? is there a significant gain to CC:R/T for doing this? |
I don't think so, and even if, the difference should be marginal but if the jar size can be smaller without a drawback then why not? |
Enable Pre-Commit, and Github actions on your fork, make sure both checks validate as the mod currently is not compiling through github actions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second commit breaks our fabric.mod.json.
We will have to think on this one as currently it provides a full megabyte size reduction from the current build |
another proposition would be to just use ImgBot? |
could you re-open this PR here? also enable pre-commit and please the linter. |
Lossless compression made with the Leanify tool.