[GH-29] Read credentials from ENV or secrets. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentsherman
reviewed
Jul 11, 2023
plugins/nf-float/src/main/com/memverge/nextflow/FloatConf.groovy
Outdated
Show resolved
Hide resolved
plugins/nf-float/src/main/com/memverge/nextflow/FloatConf.groovy
Outdated
Show resolved
Hide resolved
Comment on lines
83
to
85
| addresses = (node.address as Collection).collect { | ||
| it.toString() | ||
| } |
There was a problem hiding this comment.
Suggested change
| addresses = (node.address as Collection).collect { | |
| it.toString() | |
| } | |
| addresses = node.address*.toString() |
There was a problem hiding this comment.
When you check the type with instanceof like this, you don't have to cast it
There was a problem hiding this comment.
I use your change but looks like it cannot pass the compile.
[Static type checking] - Spread operator can only be used on collection types
@ line 77, column 29.
addresses = node.address*.toString()
I updated it to something like this:
if (node.address instanceof Collection) {
addresses = node.address.collect {it.toString()}
}There was a problem hiding this comment.
Fair enough, I guess the compiler wasn't as smart as I hoped
plugins/nf-float/src/main/com/memverge/nextflow/FloatConf.groovy
Outdated
Show resolved
Hide resolved
Enable the plugin to read credentials from the environment variable: * MMC_ADDRESS: address of the op center * MMC_USERNAME: login username * MMC_PASSWORD: login password Hide the password in the log. Add samples in the README to illustrate how to input the credentials with NextFlow secrets.
|
I added a test to verify the env changes. |
|
Looks great! |
jealous
added a commit
to jealous/plugins
that referenced
this pull request
Jul 17, 2023
Release 0.1.8 includes multiple bugfixes: * [GH-20] Update project's org. name. by @jealous in MemVerge/nf-float#21 * [nextflow-ioGH-22] Include auto-install in the document by @jealous in MemVerge/nf-float#23 * [nextflow-ioGH-26] Support config in process. by @jealous in MemVerge/nf-float#33 * [nextflow-ioGH-32] Upload bin directory. by @jealous in MemVerge/nf-float#34 * [nextflow-ioGH-28] Correct syntax in README. by @jealous in MemVerge/nf-float#36 * [nextflow-ioGH-29] Read credentials from ENV or secrets. by @jealous in MemVerge/nf-float#35 * [nextflow-ioGH-38] Track job with tags by @jealous in MemVerge/nf-float#39 * [nextflow-ioGH-37] Support default registry. by @jealous in MemVerge/nf-float#40 **Full Changelog**: MemVerge/nf-float@0.1.7...0.1.8
pditommaso
pushed a commit
to nextflow-io/plugins
that referenced
this pull request
Jul 17, 2023
Release 0.1.8 includes multiple bugfixes: * [GH-20] Update project's org. name. by @jealous in MemVerge/nf-float#21 * [GH-22] Include auto-install in the document by @jealous in MemVerge/nf-float#23 * [GH-26] Support config in process. by @jealous in MemVerge/nf-float#33 * [GH-32] Upload bin directory. by @jealous in MemVerge/nf-float#34 * [GH-28] Correct syntax in README. by @jealous in MemVerge/nf-float#36 * [GH-29] Read credentials from ENV or secrets. by @jealous in MemVerge/nf-float#35 * [GH-38] Track job with tags by @jealous in MemVerge/nf-float#39 * [GH-37] Support default registry. by @jealous in MemVerge/nf-float#40 **Full Changelog**: MemVerge/nf-float@0.1.7...0.1.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the plugin to read credentials from the environment variable:
Hide the password in the log.
Add samples in the README to illustrate how to input the credentials with NextFlow secrets.