[GH-32] Upload bin directory. #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like you are uploading the bin dir on every task invocation. This will not scale well when you have 10,000's of tasks. Can you do the upload once when the executor is created? Here is how AWS Batch does it: |
|
AWS Batch copies the bin dir into the work dir, something like |
|
Yes. This is not efficient. The reason is I couldn't find a way to insert the path. Let me do more investigation. |
jealous
force-pushed
the
bugfix/uploadBin
branch
from
e894824 to
e593040
Compare
If the workflow contains a bin directory, upload to a tmp directory in the working directory. In `.command.run` script, we add `export PATH=...` to include the tmp directory.
jealous
force-pushed
the
bugfix/uploadBin
branch
from
e593040 to
87eec32
Compare
|
Looks good to me 👍 |
jealous
added a commit
to jealous/plugins
that referenced
this pull request
Jul 17, 2023
Release 0.1.8 includes multiple bugfixes: * [GH-20] Update project's org. name. by @jealous in MemVerge/nf-float#21 * [nextflow-ioGH-22] Include auto-install in the document by @jealous in MemVerge/nf-float#23 * [nextflow-ioGH-26] Support config in process. by @jealous in MemVerge/nf-float#33 * [nextflow-ioGH-32] Upload bin directory. by @jealous in MemVerge/nf-float#34 * [nextflow-ioGH-28] Correct syntax in README. by @jealous in MemVerge/nf-float#36 * [nextflow-ioGH-29] Read credentials from ENV or secrets. by @jealous in MemVerge/nf-float#35 * [nextflow-ioGH-38] Track job with tags by @jealous in MemVerge/nf-float#39 * [nextflow-ioGH-37] Support default registry. by @jealous in MemVerge/nf-float#40 **Full Changelog**: MemVerge/nf-float@0.1.7...0.1.8
pditommaso
pushed a commit
to nextflow-io/plugins
that referenced
this pull request
Jul 17, 2023
Release 0.1.8 includes multiple bugfixes: * [GH-20] Update project's org. name. by @jealous in MemVerge/nf-float#21 * [GH-22] Include auto-install in the document by @jealous in MemVerge/nf-float#23 * [GH-26] Support config in process. by @jealous in MemVerge/nf-float#33 * [GH-32] Upload bin directory. by @jealous in MemVerge/nf-float#34 * [GH-28] Correct syntax in README. by @jealous in MemVerge/nf-float#36 * [GH-29] Read credentials from ENV or secrets. by @jealous in MemVerge/nf-float#35 * [GH-38] Track job with tags by @jealous in MemVerge/nf-float#39 * [GH-37] Support default registry. by @jealous in MemVerge/nf-float#40 **Full Changelog**: MemVerge/nf-float@0.1.7...0.1.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the workflow contains a bin directory, upload to a tmp directory in the working directory.
In
.command.runscript, we addexport PATH=...to include the tmp directory.