Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: linting on generated code #47

Merged
merged 3 commits into from
Nov 12, 2023

Conversation

mimatache
Copy link
Contributor

@mimatache mimatache commented Nov 9, 2023

This PR will run golangci-lint against all the generated repositories.

Things to improve:

  • Don't install golangci-lint for each item in the matrix
  • Uses golangci-lint predefined action
  • Add a .golangci.yaml file with desired linter configuration

resolve #39

@Melkeydev
Copy link
Owner

Checking out this PR and on your local branch I see that all the builds are failing 🤔
https://github.com/mimatache/go-blueprint/actions

Is there working pipelines that I can see 😓

@mimatache
Copy link
Contributor Author

Checking out this PR and on your local branch I see that all the builds are failing 🤔 https://github.com/mimatache/go-blueprint/actions

Is there working pipelines that I can see 😓

What is failing is not the new workflow, but the one was already failing the main repository earlier that is breaking my actions as well:
image

I can't seem to get the actions to trigger right now (didn't even see them running on mine before). Do you have any advice on how to get them to run (note, my workflow might not event start until it was merged into main).

@mimatache
Copy link
Contributor Author

@Melkeydev can you try approving the workflows so we can see if they run/pass here? I don't have the option from my branch to run it.

Copy link
Owner

@Melkeydev Melkeydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Melkeydev Melkeydev merged commit 3d6693c into Melkeydev:main Nov 12, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linting on generated code
2 participants