Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting on generated code #39

Closed
MitchellBerend opened this issue Nov 7, 2023 · 0 comments · Fixed by #47
Closed

Linting on generated code #39

MitchellBerend opened this issue Nov 7, 2023 · 0 comments · Fixed by #47

Comments

@MitchellBerend
Copy link
Contributor

PR #28 adds a workflow for linting the cli code but this does not lint the template code since that is just a string in the go code. Maybe it would be nice to have CI generate all templates to run the linter on those as well. That users don't have to manually check the generated code with the linter.
mimatache added a commit to mimatache/go-blueprint that referenced this issue Nov 9, 2023
@mimatache
ci: linting on generated code
300d051 
resolve Melkeydev#39
@mimatache mimatache mentioned this issue Nov 9, 2023
Merged
mimatache added a commit to mimatache/go-blueprint that referenced this issue Nov 10, 2023
@mimatache
ci: linting on generated code
6059315 
resolve Melkeydev#39
mimatache added a commit to mimatache/go-blueprint that referenced this issue Nov 11, 2023
@mimatache
ci: linting on generated code
f37e326 
resolve Melkeydev#39
mimatache added a commit to mimatache/go-blueprint that referenced this issue Nov 12, 2023
@mimatache
ci: linting on generated code
4b8baf1 
resolve Melkeydev#39
Melkeydev pushed a commit that referenced this issue Nov 12, 2023
@mimatache
ci: linting on generated code (#47)
3d6693c 
* ci: linting on generated code

resolve #39

* ci: use golangci-lint action with working-directory

* ci: add manual trigger for workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: linting on generated code mimatache/go-blueprint
1 participant
@MitchellBerend