Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.28] Fix some typo for include folder #9387

Merged
merged 1 commit into from
Jul 17, 2024
Merged

[Backport 2.28] Fix some typo for include folder #9387

merged 1 commit into from
Jul 17, 2024

Conversation

eleuzi01
Copy link
Contributor

Description

Partial backport of #9287 (some files do not exist in 2.28)

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@eleuzi01 eleuzi01 added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review size-xs Estimated task size: extra small (a few hours at most) labels Jul 11, 2024
This was referenced Jul 11, 2024
Merged
Merged
@eleuzi01 eleuzi01 force-pushed the backport-9287-2.28 branch from 90bef0d to 20e964f Compare July 12, 2024 08:43
@eleuzi01 eleuzi01 requested a review from sezrab July 12, 2024 10:26
@eleuzi01 eleuzi01 removed the needs-ci Needs to pass CI tests label Jul 12, 2024
sezrab
sezrab approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@sezrab sezrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm
Copy link
Contributor

@sezrab Can you update labels please? (Specifically: +approved, -needs-review, -needs-reviewer)

@eleuzi01 eleuzi01 added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Jul 17, 2024
@paul-elliott-arm paul-elliott-arm added this pull request to the merge queue Jul 17, 2024
Merged via the queue into Mbed-TLS:mbedtls-2.28 with commit 9aa9120 Jul 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

@sezrab sezrab sezrab approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports size-xs Estimated task size: extra small (a few hours at most)
Projects
Non-roadmap pull requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eleuzi01 @tom-cosgrove-arm @sezrab @paul-elliott-arm @Wenxing-hou