Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some typo for include folder #9287

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fix some typo for include folder #9287

merged 1 commit into from
Jul 17, 2024

Conversation

Wenxing-hou
Copy link

@Wenxing-hou Wenxing-hou commented Jun 19, 2024 •
edited by eleuzi01
Loading

Description

Fix some typo in Include folder.
Because the user will refer to the function description in Include folder,
it's better to fix the typo.

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

sezrab
sezrab approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@sezrab sezrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all good, thank you

@sezrab sezrab added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review size-xs Estimated task size: extra small (a few hours at most) labels Jun 19, 2024
@Wenxing-hou Wenxing-hou reopened this Jun 21, 2024
sezrab
sezrab previously approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@sezrab sezrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

eleuzi01
eleuzi01 previously approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@eleuzi01 eleuzi01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Just needs rebasing

@eleuzi01 eleuzi01 removed the needs-reviewer This PR needs someone to pick it up for review label Jul 11, 2024
@eleuzi01 eleuzi01 mentioned this pull request Jul 11, 2024
Merged
4 tasks
@eleuzi01 eleuzi01 added the needs-backports Backports are missing or are pending review and approval. label Jul 11, 2024
@eleuzi01 eleuzi01 mentioned this pull request Jul 11, 2024
Merged
4 tasks
@eleuzi01 eleuzi01 removed needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests labels Jul 11, 2024
@Wenxing-hou Wenxing-hou dismissed stale reviews from eleuzi01 and sezrab via b4d03cc July 12, 2024 07:16
@Wenxing-hou
Copy link
Author

LGTM, thanks! Just needs rebasing

Thanks. I have rebased the branch.

tom-cosgrove-arm
tom-cosgrove-arm approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I've started the CI

eleuzi01
eleuzi01 approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@eleuzi01 eleuzi01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@eleuzi01 eleuzi01 added approved Design and code approved - may be waiting for CI or backports and removed needs-backports Backports are missing or are pending review and approval. labels Jul 17, 2024
@paul-elliott-arm paul-elliott-arm added this pull request to the merge queue Jul 17, 2024
Merged via the queue into Mbed-TLS:development with commit 3962a38 Jul 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleuzi01 eleuzi01 eleuzi01 approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

@sezrab sezrab sezrab left review comments

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports size-xs Estimated task size: extra small (a few hours at most)
Projects
Non-roadmap pull requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Wenxing-hou @sezrab @tom-cosgrove-arm @eleuzi01 @paul-elliott-arm