Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 3.6] Silence gcc 12.2.0 warning #9272

Merged
merged 1 commit into from
Jul 4, 2024
Merged

[Backport 3.6] Silence gcc 12.2.0 warning #9272

merged 1 commit into from
Jul 4, 2024

Conversation

sezrab
Copy link
Contributor

@sezrab sezrab commented Jun 17, 2024

Trivial backport of #9139

PR checklist

  • changelog not required
  • 3.6 backport not required (this is the backport)
  • 2.28 backport done
  • tests no

@sezrab
Silence gcc 12.2.0 warning
38bc960 
Unfortunately this compiler complains about a variable potentially being
used un-initialized.  Silence the warning by initializing it to a sane
default.

Signed-off-by: Patrick Wildt <[email protected]>
@mpg
Copy link
Contributor

mpg commented Jun 19, 2024

@sezrab Please update the description of the parent PR #9139 to point to this PR instead of the closed #9260 as the 3.6 backport, and apply relevant labels to this PR (usually similar to the labels on the parent PR with the exception of backport status and review/approval status). (Noticed during triage.)

@sezrab sezrab added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review labels Jun 19, 2024
@sezrab sezrab mentioned this pull request Jun 19, 2024
Merged
4 tasks
@sezrab sezrab added component-crypto Crypto primitives and low-level interfaces priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most) labels Jun 19, 2024
eleuzi01
eleuzi01 approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@eleuzi01 eleuzi01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eleuzi01 eleuzi01 removed the needs-ci Needs to pass CI tests label Jun 24, 2024
gilles-peskine-arm
gilles-peskine-arm approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gilles-peskine-arm gilles-peskine-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Jul 4, 2024
@gilles-peskine-arm gilles-peskine-arm added this pull request to the merge queue Jul 4, 2024
Merged via the queue into Mbed-TLS:mbedtls-3.6 with commit 41204b8 Jul 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleuzi01 eleuzi01 eleuzi01 approved these changes

@gilles-peskine-arm gilles-peskine-arm gilles-peskine-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-crypto Crypto primitives and low-level interfaces priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most)
Projects
Non-roadmap pull requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sezrab @mpg @gilles-peskine-arm @eleuzi01