Silence gcc 12.2.0 warning #9139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately this compiler complains about a variable potentially being used un-initialized. Silence the warning by initializing it to a sane default. Signed-off-by: Patrick Wildt <[email protected]>
gilles-peskine-arm
added
needs-review
| @@ -263,7 +263,7 @@ const mbedtls_cipher_info_t *mbedtls_cipher_info_from_psa( | |||
| { | |||
| mbedtls_cipher_mode_t mode; | |||
| psa_status_t status; | |||
| mbedtls_cipher_id_t cipher_id_tmp; | |||
| mbedtls_cipher_id_t cipher_id_tmp = MBEDTLS_CIPHER_ID_NONE; | |||
There was a problem hiding this comment.
I and our CI can't reproduce the warning with gcc-12 -Wall -Wextra (which includes -Wmaybe-uninitialized). How did you get it? But explicitly initializing a variable isn't a bad thing anyway.
This code also exists in the mbedtls-3.6 and mbedtls-2.28 branches, so please make backport pull requests to these branches. By the way, please keep the “PR checklist” section in the pull request template, we need it for gatekeeping.
There was a problem hiding this comment.
I can't reproduce this with gcc 12.0.1, so I presume it's new with gcc 12.2
There was a problem hiding this comment.
On my machine and the CI, it's gcc-12 (Ubuntu 12.3.0-1ubuntu1~22.04) 12.3.0 amd64
tom-cosgrove-arm
approved these changes
May 16, 2024
tom-cosgrove-arm
added
approved
This was referenced Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately this compiler complains about a variable potentially being used un-initialized. Silence the warning by initializing it to a sane default.
PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")