-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: open button navigates to web browser's file system view #91
Comments
I guess this is a duplicated of #88 |
@Martichou I looked at #88 and I'm sure this is not a duplicate of that issue. Could you reopen this one? |
Indeed, my bad. Can I ask what was the name of the payload that triggered this issue? Do you have the issue with EVERY payload? |
I tried to reproduce this bug, but now it seems that the open button doesn't do anything anymore for me. To be fair I did recently update from Fedora 39 to Fedora 40 so that may have something to do with it. I am running the AppImage by the way. I ran the app image from the command line in order to see logs, but I didn't see any relevent errors in response to the open button in the output. This is part of the output from a payload I sent.
It didn't trigger the web browser to open though. |
Also, I didn't see any error output in web console inside the application. |
Can you give me the full log from the consol when setting the log level to trace? |
Here you go:
|
Does https://manpages.ubuntu.com/manpages/focal/man1/xdg-open.1.html |
Yes,
and this is from the terminal
Other info App
|
I'm not sure if you'd be able to do the following, but that would help me confirm that the issue is from either open-rs or from a system configuration on your side (maybe?). https://gist.github.com/Martichou/dc2e076435e27c74e2433f789d98cfba It's just a very basic Rust binary (you need to create it yourself) which open "/" and "https://github.com/Martichou/rquickshare".
|
The program ran as expected so I guess there must be an issue with my system config? |
I'm not sure, if the program ran as expected, this would mean the issue comes from somewhere else as my code in rquickshare doesn't do anything different than what was in the small example I asked you to try. |
Could you do what I asked here: #88 (comment) ? |
Here you are
|
I want to add that with this build the file explorer opens now, but not the web url I tried above. |
Signed-off-by: Martichou <[email protected]>
I will have another debug version to test here trying to use another methods for the open that outlives the app, maybe that's the issue: Attempt number 1: https://github.com/Martichou/rquickshare/actions/runs/10323595105?pr=155 And another attempt by using Tauri's shell open instead of open-rs: Attempt number 2: https://github.com/Martichou/rquickshare/actions/runs/10323802425?pr=154 |
Signed-off-by: Martichou <[email protected]>
Signed-off-by: Martichou <[email protected]>
For example, an image was transferred:
Clicking "open" navigates to a new browser tab, in my instance a firefox tab showing the file system directory the file was saved to:
I think it would make more sense if the open button navigates to the built-in file explorer, with the transferred file being highlighted (Show in folder). Another thing that would make sense would be to open the file directly (Open / View).
Also to make this a little more convenient for the end user it should display the file name also:
Current:
The text was updated successfully, but these errors were encountered: