Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: open button navigates to web browser's file system view #91

Closed
jon-dez opened this issue May 31, 2024 · 17 comments
Closed

bug: open button navigates to web browser's file system view #91

jon-dez opened this issue May 31, 2024 · 17 comments
Labels
bug Something isn't working

Comments

@jon-dez
Copy link

jon-dez commented May 31, 2024

For example, an image was transferred:

image

Clicking "open" navigates to a new browser tab, in my instance a firefox tab showing the file system directory the file was saved to:

image

I think it would make more sense if the open button navigates to the built-in file explorer, with the transferred file being highlighted (Show in folder). Another thing that would make sense would be to open the file directly (Open / View).

Also to make this a little more convenient for the end user it should display the file name also:

Received file
FILE.ext
Saved to DIRECTORY

Current:

Received
Saved to DIRECTORY
@Martichou
Copy link
Owner

I guess this is a duplicated of #88

@Martichou Martichou closed this as not planned Won't fix, can't repro, duplicate, stale Jun 19, 2024
@jon-dez
Copy link
Author

jon-dez commented Jun 20, 2024

@Martichou I looked at #88 and I'm sure this is not a duplicate of that issue. Could you reopen this one?

@Martichou Martichou reopened this Jun 20, 2024
@Martichou
Copy link
Owner

Indeed, my bad. Can I ask what was the name of the payload that triggered this issue?

Do you have the issue with EVERY payload?

@Martichou Martichou changed the title Open button navigates to web browser's file system view bug: open button navigates to web browser's file system view Jun 20, 2024
@Martichou Martichou added the bug Something isn't working label Jun 20, 2024
@jon-dez
Copy link
Author

jon-dez commented Jun 20, 2024

I tried to reproduce this bug, but now it seems that the open button doesn't do anything anymore for me. To be fair I did recently update from Fedora 39 to Fedora 40 so that may have something to do with it. I am running the AppImage by the way. I ran the app image from the command line in order to see logs, but I didn't see any relevent errors in response to the open button in the output. This is part of the output from a payload I sent.

2024-06-20T11:37:04Z  INFO rquickshare::cmds::open_url: open: "https://github.com/Martichou/rquickshare"

It didn't trigger the web browser to open though.

@jon-dez
Copy link
Author

jon-dez commented Jun 20, 2024

Also, I didn't see any error output in web console inside the application.

@Martichou
Copy link
Owner

Can you give me the full log from the consol when setting the log level to trace?
Like so #104 (comment).

@jon-dez
Copy link
Author

jon-dez commented Jun 21, 2024

Here you go:

$ ./r-quick-share_0.8.2_amd64.AppImage 
set_up_logging: level from config: "trace"
set_up_logging: level: Trace
2024-06-21T03:07:13Z DEBUG rquickshare::logger: Finished setting up logging! yay!
2024-06-21T03:07:13Z DEBUG rquickshare: Starting setup of RQuickShare app
2024-06-21T03:07:13Z TRACE rquickshare: Beginning of RQS start
2024-06-21T03:07:13Z  INFO rqs_lib: TcpListener on: 0.0.0.0:42541
2024-06-21T03:07:13Z  INFO rqs_lib::manager: TcpServer: service starting
2024-06-21T03:07:13Z  INFO rqs_lib::hdl::mdns: Broadcasting with: jon-dez-fed
2024-06-21T03:07:13Z  INFO rqs_lib::hdl::ble: BleListener: service starting
2024-06-21T03:07:13Z  INFO rqs_lib::hdl::mdns: MDnsServer: service starting
2024-06-21T03:07:13Z DEBUG rqs_lib::hdl::mdns: MDnsServer: visibility changed: Visible

** (r-quick-share:3107831): WARNING **: 23:07:38.984: atk-bridge: get_device_events_reply: unknown signature
2024-06-21T03:12:29Z DEBUG rqs_lib::hdl::ble: BleListener: A device (hci0/dev_D4_3A_2C_64_EA_0B) is sharing ({0000fe2c-0000-1000-8000-00805f9b34fb: [252, 18, 142, 5, 66, 0, 0, 0, 0, 0, 0, 0, 0, 0, 13, 159, 75, 200, 67, 217, 226, 51, 93, 0]}) nearby
2024-06-21T03:12:29Z DEBUG rqs_lib::hdl::mdns: MDnsServer: ble_receiver: got event
2024-06-21T03:12:29Z TRACE rquickshare: Tauri: ble received: Visible
2024-06-21T03:12:38Z TRACE rqs_lib::manager: TcpServer: new client: 192.168.1.200:50542
2024-06-21T03:12:39Z DEBUG rqs_lib::hdl::inbound: Handling State::Initial frame
2024-06-21T03:12:39Z  INFO rqs_lib::hdl::inbound: RemoteDeviceInfo: RemoteDeviceInfo { name: "Jonathan's Pixel 8 Pro", device_type: Phone }
2024-06-21T03:12:39Z DEBUG rqs_lib::hdl::inbound: Handling State::ReceivedConnectionRequest frame
2024-06-21T03:12:39Z TRACE rqs_lib::hdl::inbound: CipherCommitment: P256Sha512
2024-06-21T03:12:39Z DEBUG rqs_lib::hdl::inbound: Handling State::SentUkeyServerInit frame
2024-06-21T03:12:39Z  INFO rqs_lib::hdl::inbound: Pin code: Some("7844")
2024-06-21T03:12:39Z DEBUG rqs_lib::hdl::inbound: Handling State::ReceivedUkeyClientFinish frame
2024-06-21T03:12:39Z DEBUG rqs_lib::hdl::inbound: Handling SecureMessage frame
2024-06-21T03:12:39Z TRACE rqs_lib::hdl::inbound: Received FrameType::PayloadTransfer
2024-06-21T03:12:39Z  INFO rqs_lib::hdl::inbound: Processing PayloadType::Bytes
2024-06-21T03:12:39Z DEBUG rqs_lib::hdl::inbound: Handling SecureMessage frame
2024-06-21T03:12:39Z TRACE rqs_lib::hdl::inbound: Received FrameType::PayloadTransfer
2024-06-21T03:12:39Z  INFO rqs_lib::hdl::inbound: Processing PayloadType::Bytes
2024-06-21T03:12:39Z DEBUG rqs_lib::hdl::inbound: Chunk flags & 1 == 1 ?? End of data ??
2024-06-21T03:12:39Z DEBUG rqs_lib::hdl::inbound: Processing State::SentConnectionResponse
2024-06-21T03:12:39Z DEBUG rqs_lib::hdl::inbound: Handling SecureMessage frame
2024-06-21T03:12:39Z TRACE rqs_lib::hdl::inbound: Received FrameType::PayloadTransfer
2024-06-21T03:12:39Z  INFO rqs_lib::hdl::inbound: Processing PayloadType::Bytes
2024-06-21T03:12:39Z DEBUG rqs_lib::hdl::inbound: Handling SecureMessage frame
2024-06-21T03:12:39Z TRACE rqs_lib::hdl::inbound: Received FrameType::PayloadTransfer
2024-06-21T03:12:39Z  INFO rqs_lib::hdl::inbound: Processing PayloadType::Bytes
2024-06-21T03:12:39Z DEBUG rqs_lib::hdl::inbound: Chunk flags & 1 == 1 ?? End of data ??
2024-06-21T03:12:39Z DEBUG rqs_lib::hdl::inbound: Processing State::SentPairedKeyResult
2024-06-21T03:12:40Z DEBUG rqs_lib::hdl::inbound: Handling SecureMessage frame
2024-06-21T03:12:40Z TRACE rqs_lib::hdl::inbound: Received FrameType::PayloadTransfer
2024-06-21T03:12:40Z  INFO rqs_lib::hdl::inbound: Processing PayloadType::Bytes
2024-06-21T03:12:40Z DEBUG rqs_lib::hdl::inbound: Handling SecureMessage frame
2024-06-21T03:12:40Z TRACE rqs_lib::hdl::inbound: Received FrameType::PayloadTransfer
2024-06-21T03:12:40Z  INFO rqs_lib::hdl::inbound: Processing PayloadType::Bytes
2024-06-21T03:12:40Z DEBUG rqs_lib::hdl::inbound: Chunk flags & 1 == 1 ?? End of data ??
2024-06-21T03:12:40Z DEBUG rqs_lib::hdl::inbound: Processing State::ReceivedPairedKeyResult
2024-06-21T03:12:40Z TRACE rqs_lib::hdl::inbound: process_introduction: handling text_metadata
2024-06-21T03:12:40Z  INFO rqs_lib::hdl::inbound: Asking for user consent: TransferMetadata { id: "192.168.1.200:50542", destination: None, source: Some(RemoteDeviceInfo { name: "Jonathan's Pixel 8 Pro", device_type: Phone }), files: None, pin_code: Some("7844"), text_description: Some("https://github.com/Martichou/rqu…"), text_payload: None, total_bytes: 0, ack_bytes: 0 }
2024-06-21T03:12:40Z TRACE rqs_lib::hdl::inbound: Sending msg into the channel
2024-06-21T03:12:40Z  INFO rquickshare: rs2js_channelmessage: ChannelMessage { id: "192.168.1.200:50542", direction: LibToFront, action: None, rtype: Some(Inbound), state: Some(WaitingForUserConsent), meta: Some(TransferMetadata { id: "192.168.1.200:50542", destination: None, source: Some(RemoteDeviceInfo { name: "Jonathan's Pixel 8 Pro", device_type: Phone }), files: None, pin_code: Some("7844"), text_description: Some("https://github.com/Martichou/rqu…"), text_payload: None, total_bytes: 0, ack_bytes: 0 }) }
2024-06-21T03:12:44Z  INFO rquickshare::cmds::send_to_rs: send_to_rs: ChannelMessage { id: "192.168.1.200:50542", direction: FrontToLib, action: Some(AcceptTransfer), rtype: None, state: None, meta: None }
2024-06-21T03:12:44Z DEBUG rqs_lib::hdl::inbound: inbound: got: ChannelMessage { id: "192.168.1.200:50542", direction: FrontToLib, action: Some(AcceptTransfer), rtype: None, state: None, meta: None }
2024-06-21T03:12:44Z TRACE rqs_lib::hdl::inbound: Sending msg into the channel
2024-06-21T03:12:44Z  INFO rquickshare: rs2js_channelmessage: ChannelMessage { id: "192.168.1.200:50542", direction: LibToFront, action: None, rtype: Some(Inbound), state: Some(ReceivingFiles), meta: Some(TransferMetadata { id: "192.168.1.200:50542", destination: None, source: Some(RemoteDeviceInfo { name: "Jonathan's Pixel 8 Pro", device_type: Phone }), files: None, pin_code: Some("7844"), text_description: Some("https://github.com/Martichou/rqu…"), text_payload: None, total_bytes: 0, ack_bytes: 0 }) }
2024-06-21T03:12:44Z DEBUG rqs_lib::hdl::inbound: Handling SecureMessage frame
2024-06-21T03:12:44Z ERROR rqs_lib::hdl::inbound: Unhandled offline frame encrypted: OfflineFrame { version: Some(V1), v1: Some(V1Frame { r#type: Some(12), connection_request: None, connection_response: None, payload_transfer: None, bandwidth_upgrade_negotiation: None, keep_alive: None, disconnection: None, paired_key_encryption: None }) }
2024-06-21T03:12:44Z DEBUG rqs_lib::hdl::inbound: Handling SecureMessage frame
2024-06-21T03:12:44Z TRACE rqs_lib::hdl::inbound: Received FrameType::PayloadTransfer
2024-06-21T03:12:44Z  INFO rqs_lib::hdl::inbound: Processing PayloadType::Bytes
2024-06-21T03:12:44Z DEBUG rqs_lib::hdl::inbound: Handling SecureMessage frame
2024-06-21T03:12:44Z TRACE rqs_lib::hdl::inbound: Received FrameType::PayloadTransfer
2024-06-21T03:12:44Z  INFO rqs_lib::hdl::inbound: Processing PayloadType::Bytes
2024-06-21T03:12:44Z DEBUG rqs_lib::hdl::inbound: Chunk flags & 1 == 1 ?? End of data ??
2024-06-21T03:12:44Z  INFO rqs_lib::hdl::inbound: Unhandled connection state in process_transfer_setup: ReceivingFiles
2024-06-21T03:12:44Z DEBUG rqs_lib::hdl::inbound: Handling SecureMessage frame
2024-06-21T03:12:44Z TRACE rqs_lib::hdl::inbound: Received FrameType::PayloadTransfer
2024-06-21T03:12:44Z  INFO rqs_lib::hdl::inbound: Processing PayloadType::Bytes
2024-06-21T03:12:44Z DEBUG rqs_lib::hdl::inbound: Handling SecureMessage frame
2024-06-21T03:12:44Z TRACE rqs_lib::hdl::inbound: Received FrameType::PayloadTransfer
2024-06-21T03:12:44Z  INFO rqs_lib::hdl::inbound: Processing PayloadType::Bytes
2024-06-21T03:12:44Z DEBUG rqs_lib::hdl::inbound: Chunk flags & 1 == 1 ?? End of data ??
2024-06-21T03:12:44Z  INFO rqs_lib::hdl::inbound: Transfer finished
2024-06-21T03:12:44Z TRACE rqs_lib::hdl::inbound: Sending msg into the channel
2024-06-21T03:12:44Z  INFO rquickshare: rs2js_channelmessage: ChannelMessage { id: "192.168.1.200:50542", direction: LibToFront, action: None, rtype: Some(Inbound), state: Some(Finished), meta: Some(TransferMetadata { id: "192.168.1.200:50542", destination: None, source: Some(RemoteDeviceInfo { name: "Jonathan's Pixel 8 Pro", device_type: Phone }), files: None, pin_code: Some("7844"), text_description: Some("https://github.com/Martichou/rqu…"), text_payload: Some("https://github.com/Martichou/rquickshare"), total_bytes: 0, ack_bytes: 0 }) }
2024-06-21T03:12:46Z  INFO rquickshare::cmds::open_url: open: "https://github.com/Martichou/rquickshare"

@Martichou
Copy link
Owner

@jon-dez
Copy link
Author

jon-dez commented Aug 6, 2024

Yes, xdg-open URL does work for me when I invoke from the terminal, although I get an error in the developer console (in rquickshare):

[Error] Coudln't open: Launcher "xdg-open" "/home/jon/Downloads" failed with ExitStatus(unix_wait_status(768))
	am (index-WYDG3mFU.js:13:610)
	tr (index-WYDG3mFU.js:13:563)
	(anonymous function) (index-WYDG3mFU.js:13:153)

and this is from the terminal

2024-08-06T05:06:04Z  INFO rquickshare::cmds::open_url: open: "/home/jon/Downloads"

Other info

App

r-quick-share-legacy_v0.10.2_glibc-2.31_amd64.AppImage

@Martichou
Copy link
Owner

I'm not sure if you'd be able to do the following, but that would help me confirm that the issue is from either open-rs or from a system configuration on your side (maybe?).

https://gist.github.com/Martichou/dc2e076435e27c74e2433f789d98cfba

It's just a very basic Rust binary (you need to create it yourself) which open "/" and "https://github.com/Martichou/rquickshare".

cargo new --bin open-rs-test
cd open-rs-test
# Modify Cargo.toml & src/main.rs

@jon-dez
Copy link
Author

jon-dez commented Aug 8, 2024

The program ran as expected so I guess there must be an issue with my system config?

@Martichou
Copy link
Owner

I'm not sure, if the program ran as expected, this would mean the issue comes from somewhere else as my code in rquickshare doesn't do anything different than what was in the small example I asked you to try.

@Martichou
Copy link
Owner

Martichou commented Aug 8, 2024

Could you do what I asked here: #88 (comment) ?

@jon-dez
Copy link
Author

jon-dez commented Aug 9, 2024

Here you are

./r-quick-share-main_v0.10.2_glibc-2.39_amd64.AppImage 
set_up_logging: level from config: "trace"
set_up_logging: level: Trace
2024-08-09T10:29:13Z DEBUG rquickshare::logger: Finished setting up logging! yay!
2024-08-09T10:29:13Z DEBUG rquickshare: Starting setup of RQuickShare app
2024-08-09T10:29:13Z TRACE rquickshare: Beginning of RQS start
2024-08-09T10:29:13Z  INFO rqs_lib: TcpListener on: 0.0.0.0:42709
2024-08-09T10:29:13Z  INFO rqs_lib::manager: TcpServer: service starting
2024-08-09T10:29:13Z  INFO rqs_lib::hdl::mdns: Broadcasting with: jon-dez-fed
2024-08-09T10:29:13Z  INFO rqs_lib::hdl::ble: BleListener: service starting
2024-08-09T10:29:13Z  INFO rqs_lib::hdl::mdns: MDnsServer: service starting
2024-08-09T10:29:13Z DEBUG rqs_lib::hdl::mdns: MDnsServer: visibility changed: Visible
2024-08-09T10:29:13Z TRACE rquickshare: RunEvent::Ready
2024-08-09T10:32:03Z TRACE rqs_lib::manager: TcpServer: new client: 192.168.1.200:52670
2024-08-09T10:32:04Z DEBUG rqs_lib::hdl::inbound: Handling State::Initial frame
2024-08-09T10:32:04Z  INFO rqs_lib::hdl::inbound: RemoteDeviceInfo: RemoteDeviceInfo { name: "Jonathan's Pixel 8 Pro", device_type: Phone }
2024-08-09T10:32:04Z DEBUG rqs_lib::hdl::inbound: Handling State::ReceivedConnectionRequest frame
2024-08-09T10:32:04Z TRACE rqs_lib::hdl::inbound: CipherCommitment: P256Sha512
2024-08-09T10:32:04Z DEBUG rqs_lib::hdl::inbound: Handling State::SentUkeyServerInit frame
2024-08-09T10:32:04Z  INFO rqs_lib::hdl::inbound: Pin code: Some("9483")
2024-08-09T10:32:04Z DEBUG rqs_lib::hdl::inbound: Handling State::ReceivedUkeyClientFinish frame
2024-08-09T10:32:04Z DEBUG rqs_lib::hdl::inbound: Handling SecureMessage frame
2024-08-09T10:32:04Z TRACE rqs_lib::hdl::inbound: Received FrameType::PayloadTransfer
2024-08-09T10:32:04Z  INFO rqs_lib::hdl::inbound: Processing PayloadType::Bytes
2024-08-09T10:32:04Z DEBUG rqs_lib::hdl::inbound: Handling SecureMessage frame
2024-08-09T10:32:04Z TRACE rqs_lib::hdl::inbound: Received FrameType::PayloadTransfer
2024-08-09T10:32:04Z  INFO rqs_lib::hdl::inbound: Processing PayloadType::Bytes
2024-08-09T10:32:04Z DEBUG rqs_lib::hdl::inbound: Chunk flags & 1 == 1 ?? End of data ??
2024-08-09T10:32:04Z DEBUG rqs_lib::hdl::inbound: Processing State::SentConnectionResponse
2024-08-09T10:32:04Z DEBUG rqs_lib::hdl::inbound: Handling SecureMessage frame
2024-08-09T10:32:04Z TRACE rqs_lib::hdl::inbound: Received FrameType::PayloadTransfer
2024-08-09T10:32:04Z  INFO rqs_lib::hdl::inbound: Processing PayloadType::Bytes
2024-08-09T10:32:04Z DEBUG rqs_lib::hdl::inbound: Handling SecureMessage frame
2024-08-09T10:32:04Z TRACE rqs_lib::hdl::inbound: Received FrameType::PayloadTransfer
2024-08-09T10:32:04Z  INFO rqs_lib::hdl::inbound: Processing PayloadType::Bytes
2024-08-09T10:32:04Z DEBUG rqs_lib::hdl::inbound: Chunk flags & 1 == 1 ?? End of data ??
2024-08-09T10:32:04Z DEBUG rqs_lib::hdl::inbound: Processing State::SentPairedKeyResult
2024-08-09T10:32:04Z DEBUG rqs_lib::hdl::inbound: Handling SecureMessage frame
2024-08-09T10:32:04Z TRACE rqs_lib::hdl::inbound: Received FrameType::PayloadTransfer
2024-08-09T10:32:04Z  INFO rqs_lib::hdl::inbound: Processing PayloadType::Bytes
2024-08-09T10:32:04Z DEBUG rqs_lib::hdl::inbound: Handling SecureMessage frame
2024-08-09T10:32:04Z TRACE rqs_lib::hdl::inbound: Received FrameType::PayloadTransfer
2024-08-09T10:32:04Z  INFO rqs_lib::hdl::inbound: Processing PayloadType::Bytes
2024-08-09T10:32:04Z DEBUG rqs_lib::hdl::inbound: Chunk flags & 1 == 1 ?? End of data ??
2024-08-09T10:32:04Z DEBUG rqs_lib::hdl::inbound: Processing State::ReceivedPairedKeyResult
2024-08-09T10:32:04Z TRACE rqs_lib::hdl::inbound: process_introduction: handling text_metadata
2024-08-09T10:32:04Z  INFO rqs_lib::hdl::inbound: Asking for user consent: TransferMetadata { id: "192.168.1.200:52670", destination: None, source: Some(RemoteDeviceInfo { name: "Jonathan's Pixel 8 Pro", device_type: Phone }), files: None, pin_code: Some("9483"), text_description: Some("https://github.com/Martichou/rqu…"), text_payload: None, total_bytes: 0, ack_bytes: 0 }
2024-08-09T10:32:04Z TRACE rqs_lib::hdl::inbound: Sending msg into the channel
2024-08-09T10:32:04Z  INFO rquickshare: rs2js_channelmessage: ChannelMessage { id: "192.168.1.200:52670", direction: LibToFront, action: None, rtype: Some(Inbound), state: Some(WaitingForUserConsent), meta: Some(TransferMetadata { id: "192.168.1.200:52670", destination: None, source: Some(RemoteDeviceInfo { name: "Jonathan's Pixel 8 Pro", device_type: Phone }), files: None, pin_code: Some("9483"), text_description: Some("https://github.com/Martichou/rqu…"), text_payload: None, total_bytes: 0, ack_bytes: 0 }) }
2024-08-09T10:32:08Z  INFO rquickshare::cmds::send_to_rs: send_to_rs: ChannelMessage { id: "192.168.1.200:52670", direction: FrontToLib, action: Some(AcceptTransfer), rtype: None, state: None, meta: None }
2024-08-09T10:32:08Z DEBUG rqs_lib::hdl::inbound: Handling SecureMessage frame
2024-08-09T10:32:08Z ERROR rqs_lib::hdl::inbound: Unhandled offline frame encrypted: OfflineFrame { version: Some(V1), v1: Some(V1Frame { r#type: Some(12), connection_request: None, connection_response: None, payload_transfer: None, bandwidth_upgrade_negotiation: None, keep_alive: None, disconnection: None, paired_key_encryption: None }) }
2024-08-09T10:32:08Z DEBUG rqs_lib::hdl::inbound: inbound: got: ChannelMessage { id: "192.168.1.200:52670", direction: FrontToLib, action: Some(AcceptTransfer), rtype: None, state: None, meta: None }
2024-08-09T10:32:08Z TRACE rqs_lib::hdl::inbound: Sending msg into the channel
2024-08-09T10:32:08Z  INFO rquickshare: rs2js_channelmessage: ChannelMessage { id: "192.168.1.200:52670", direction: LibToFront, action: None, rtype: Some(Inbound), state: Some(ReceivingFiles), meta: Some(TransferMetadata { id: "192.168.1.200:52670", destination: None, source: Some(RemoteDeviceInfo { name: "Jonathan's Pixel 8 Pro", device_type: Phone }), files: None, pin_code: Some("9483"), text_description: Some("https://github.com/Martichou/rqu…"), text_payload: None, total_bytes: 0, ack_bytes: 0 }) }
2024-08-09T10:32:08Z DEBUG rqs_lib::hdl::inbound: Handling SecureMessage frame
2024-08-09T10:32:08Z TRACE rqs_lib::hdl::inbound: Received FrameType::PayloadTransfer
2024-08-09T10:32:08Z  INFO rqs_lib::hdl::inbound: Processing PayloadType::Bytes
2024-08-09T10:32:08Z DEBUG rqs_lib::hdl::inbound: Handling SecureMessage frame
2024-08-09T10:32:08Z TRACE rqs_lib::hdl::inbound: Received FrameType::PayloadTransfer
2024-08-09T10:32:08Z  INFO rqs_lib::hdl::inbound: Processing PayloadType::Bytes
2024-08-09T10:32:08Z DEBUG rqs_lib::hdl::inbound: Chunk flags & 1 == 1 ?? End of data ??
2024-08-09T10:32:08Z  INFO rqs_lib::hdl::inbound: Unhandled connection state in process_transfer_setup: ReceivingFiles
2024-08-09T10:32:08Z DEBUG rqs_lib::hdl::inbound: Handling SecureMessage frame
2024-08-09T10:32:08Z TRACE rqs_lib::hdl::inbound: Received FrameType::PayloadTransfer
2024-08-09T10:32:08Z  INFO rqs_lib::hdl::inbound: Processing PayloadType::Bytes
2024-08-09T10:32:08Z DEBUG rqs_lib::hdl::inbound: Handling SecureMessage frame
2024-08-09T10:32:08Z TRACE rqs_lib::hdl::inbound: Received FrameType::PayloadTransfer
2024-08-09T10:32:08Z  INFO rqs_lib::hdl::inbound: Processing PayloadType::Bytes
2024-08-09T10:32:08Z DEBUG rqs_lib::hdl::inbound: Chunk flags & 1 == 1 ?? End of data ??
2024-08-09T10:32:08Z  INFO rqs_lib::hdl::inbound: Transfer finished
2024-08-09T10:32:08Z ERROR rqs_lib::hdl::inbound: Cannot open URL: Launcher "xdg-open" "https://github.com/Martichou/rquickshare" failed with ExitStatus(unix_wait_status(1024))
2024-08-09T10:32:08Z TRACE rqs_lib::hdl::inbound: Sending msg into the channel
2024-08-09T10:32:08Z  INFO rquickshare: rs2js_channelmessage: ChannelMessage { id: "192.168.1.200:52670", direction: LibToFront, action: None, rtype: Some(Inbound), state: Some(Finished), meta: Some(TransferMetadata { id: "192.168.1.200:52670", destination: None, source: Some(RemoteDeviceInfo { name: "Jonathan's Pixel 8 Pro", device_type: Phone }), files: None, pin_code: Some("9483"), text_description: Some("https://github.com/Martichou/rqu…"), text_payload: Some("https://github.com/Martichou/rquickshare"), total_bytes: 0, ack_bytes: 0 }) }
2024-08-09T10:32:10Z  INFO rquickshare::cmds::open_url: open_url: "https://github.com/Martichou/rquickshare"
2024-08-09T10:32:10Z ERROR rquickshare::cmds::open_url: open_url error: Launcher "xdg-open" "https://github.com/Martichou/rquickshare" failed with ExitStatus(unix_wait_status(1024))

@jon-dez
Copy link
Author

jon-dez commented Aug 9, 2024

I want to add that with this build the file explorer opens now, but not the web url I tried above.

Martichou added a commit that referenced this issue Aug 9, 2024
@Martichou
Copy link
Owner

Martichou commented Aug 9, 2024

I will have another debug version to test here trying to use another methods for the open that outlives the app, maybe that's the issue:

Attempt number 1: https://github.com/Martichou/rquickshare/actions/runs/10323595105?pr=155

And another attempt by using Tauri's shell open instead of open-rs:

Attempt number 2: https://github.com/Martichou/rquickshare/actions/runs/10323802425?pr=154

Martichou added a commit that referenced this issue Aug 11, 2024
Martichou added a commit that referenced this issue Aug 13, 2024
@Martichou
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants