bug: open button borked #88
Labels
bug
Something isn't working
Comments
|
What's your default browser? |
|
Firefox. The .deb version, not flatpak. |
|
May I ask you if defining Chrome as the default browser does fix the issue? |
|
I don't have Chrome installed, but I tried with Ungoogled Chromium (Flatpak) and it had the same result with the same errors in the terminal. So since the same thing happened with Firefox installed from apt and a Chromium-like browser installed from flatpak, I think the browser is not the issue. Also, I don't think #91 is the same issue, since they can use the "open" button, it just uses the wrong app for the protocol. |
|
I just tested with the recently released 0.8.2 version and the same behavior happens. |
|
Can you check: |
|
This is what I get, which doesn't appear abnormal. I'm sure #91 is a seperate issue. xdg-settings --list xdg-settings get default-web-browser |
|
Basically the same for me (dw about how prepending |
|
Does https://manpages.ubuntu.com/manpages/focal/man1/xdg-open.1.html |
|
Yes, it does work. I even tested it again to make sure and the situation is the same in the current versions (0.10.2) and it is, it neither opens automatically nor does the button work. |
Martichou
added a commit
that referenced
this issue
Aug 6, 2024
Signed-off-by: Martichou <[email protected]>
|
That's very strange as I'm using https://github.com/Byron/open-rs for the open of URI. In theory it use xdg-open and will try every possible applications to open the URI. I'm adding debug in the logs hoping this will give me more info as to what is happening (f82fedd). See here for how to enable TRACE level: #104 |
|
And if it's not too much for you, you can try the following too :) Thanks! |
|
Sorry for the delay, I was busy these days. But here's the output of the trace debug: Output
|
|
Thanks! Unfortunately still nothing interesting.. sorry for that. Can you give a shot to the comment I linked in my previous message? (#91). It's a simple rust binary to see if the error is in my code or in open-rs codebase or somewhere else :) |
|
It works flawlessly with no issues whatsoever, I copy pasted your gists from that issue into their respective files and ran the project with Output
|
Martichou
added a commit
that referenced
this issue
Aug 9, 2024
Signed-off-by: Martichou <[email protected]>
|
I will have another debug version to test here trying to use another methods for the open that outlives the app, maybe that's the issue: Attempt number 1: https://github.com/Martichou/rquickshare/actions/runs/10323595105?pr=155 And another attempt by using Tauri's shell open instead of open-rs: Attempt number 2: https://github.com/Martichou/rquickshare/actions/runs/10323802425?pr=154 |
|
The Tauri one worked when I clicked "open", it didn't open automatically though. Attempt 1 Output
Attempt 2 Output
|
|
Ok so attempt 1 did not change anything, not working at all right? Strange that it doesn't trigger an error... Attempt 2, it's normal it does not open automatically, the open of URL automatically is within the core_lib which doesn't have access to Tauri's open function. We're getting there! Thanks for your help in trying to debug this one :) |
|
No problem, I really want this project to get better, since more integration between my phone and computer is always good and kdeconnect randomly disconnects sometimes so a native solution is better. When you fix this issue, I will immediately start using it everyday, thanks for such a cool project. |
Martichou
added a commit
that referenced
this issue
Aug 11, 2024
Signed-off-by: Martichou <[email protected]>
Martichou
added a commit
that referenced
this issue
Aug 13, 2024
Signed-off-by: Martichou <[email protected]>
This was referenced Aug 13, 2024
This was referenced Aug 21, 2024
|
I don't know if it's supposed to be like that or what, but I just noticed images refuse to open even in the latest version. If this is intended, maybe you could hide/disable it, but I suspect it should open the default image viewer, which doesn't happen. No errors in terminal nor in vue console, in fact, nothing gets printed even when I spam the button. Also, since the issue still has something to do with the open button, I thought opening a new issue wouldn't be necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First of all, thanks for the app, I've been searching for a quickshare for linux for a few months now and this is just perfect.
I've installed the appimage and everything else apart from the "open" button works flawlessly, so I can't click it to open links, which also don't open automatically when the sharing is done, or files.
Here's vue console shows when clicking the button in two different transfers:
If I start it from terminal, similar messages show up as well. Here's full log from application start to a url being received and some button spamming at the end:
The text was updated successfully, but these errors were encountered: