Fix MKS Robin E3 extruder SPI bus conflicts #24889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
force-pushed
the
extruder-conflict-robin-e3d
branch
from
cb68ce3 to
44a21cf
Compare
thinkyhead
changed the title
|
Not needed after all, or fixed in a different manner? |
#24380 was reopened, so I’m guessing this is still needed. |
|
So, is this a safe fix, or is it too broad and affecting other boards it should not? |
|
Is needed but is reported that it randomly locks up.. so more work is needed that just fixing the conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Default environment used SPI3, this conflicted with extruder IO pins.
SDCARD definition was a mess
Updated and cleaned up and added some useful comments.
Tested on BOARD_MKS_ROBIN_E3D_V1_1
Requirements
Any of these 4 boards with SDSUPPORT
BOARD_MKS_ROBIN_E3
BOARD_MKS_ROBIN_E3_V1_1
BOARD_MKS_ROBIN_E3D
BOARD_MKS_ROBIN_E3D_V1_1
Benefits
Extruder moves as expected.
Configurations
Bugfix 2.1.x https://github.com/MarlinFirmware/Marlin/files/9799514/changes.zip
Related Issues
#24882
#24380
#23715