cleanup

MarlinFirmware · Oct 20, 2022 · 44a21cf · 44a21cf
1 parent b2aa0d0
commit 44a21cf
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 15 deletions.
diff --git a/Marlin/src/pins/esp32/pins_ENWI_ESPNP.h b/Marlin/src/pins/esp32/pins_ENWI_ESPNP.h
@@ -106,7 +106,7 @@
 #define FAN2_PIN                             135
 #define FAN3_PIN                             136
 
-// #define FAN_SOFT_PWM_REQUIRED // check if needed
+//#define FAN_SOFT_PWM_REQUIRED // check if needed
 
 // Neopixel Rings
 #define NEOPIXEL_PIN                          14

diff --git a/Marlin/src/pins/stm32f1/pins_CREALITY_V45x.h b/Marlin/src/pins/stm32f1/pins_CREALITY_V45x.h
@@ -103,7 +103,7 @@
 // SD Card
 //
 #define SD_DETECT_PIN                       PC7
-#define NO_SD_HOST_DRIVE                          // SD is only seen by the printer
+#define NO_SD_HOST_DRIVE                          // This board's SD is only seen by the printer
 
 #define SDIO_SUPPORT                              // Extra added by Creality
 #define SDIO_CLOCK                       6000000  // In original source code overridden by Creality in sdio.h

diff --git a/Marlin/src/pins/stm32f1/pins_MKS_ROBIN_E3_common.h b/Marlin/src/pins/stm32f1/pins_MKS_ROBIN_E3_common.h
@@ -165,13 +165,13 @@
 #define EXP2_05_PIN                         PB0
 #define EXP2_06_PIN                         PB15
 #define EXP2_07_PIN                         PC10
-#define EXP2_08_PIN                         -1   // RESET
+#define EXP2_08_PIN                         -1    // RESET
 
 // "Ender-3 EXP1"
 #define EXP3_01_PIN                         PC1
 #define EXP3_02_PIN                         PC3
 #define EXP3_03_PIN                         PB11
-#define EXP3_04_PIN                         -1   // RESET
+#define EXP3_04_PIN                         -1    // RESET
 #define EXP3_05_PIN                         PB0
 #define EXP3_06_PIN                         PA6
 #define EXP3_07_PIN                         PA5
@@ -249,14 +249,16 @@
 //
 // SD Card
 //
-// DEFAULT_SPI  == 2 defines the following pins
+// DEFAULT_SPI == 2 defines the following pins,
+// used as overrides in HAL/STM32/spi_pins.h
 //
-// #define PIN_SPI_SS            PB12
-// #define PIN_SPI_MOSI          PB15
-// #define PIN_SPI_MISO          PB14
-// #define PIN_SPI_SCK           PB13
+//#define PIN_SPI_SS                        PB12
+//#define PIN_SPI_MOSI                      PB15
+//#define PIN_SPI_MISO                      PB14
+//#define PIN_SPI_SCK                       PB13
+
 //
-// Onboard SDCARD uses thes pins and is shared on EXP2 for LCD's
+// Onboard SDCARD uses these pins and is shared on EXP2 for LCDs
 //
 // SPI2_CS   PA15
 // SPI2_MOSI PB15
@@ -266,6 +268,6 @@
 
 #if ENABLED(SDSUPPORT)
   #define NO_SD_HOST_DRIVE
-  #define SDSS                                EXP2_04_PIN // PA15
-  #define SD_DETECT_PIN                       EXP2_07_PIN // PC10
-#endif 
+  #define SDSS                       EXP2_04_PIN
+  #define SD_DETECT_PIN              EXP2_07_PIN
+#endif
diff --git a/Marlin/src/pins/stm32f4/pins_MKS_MONSTER8_common.h b/Marlin/src/pins/stm32f4/pins_MKS_MONSTER8_common.h
@@ -250,7 +250,7 @@
     #define SD_SCK_PIN                      PC10
     #define SD_MISO_PIN                     PC11
     #define SD_MOSI_PIN                     PC12
-    #define SD_DETECT_PIN                   PC4   // SD_DETECT_PIN doesn't work with NO_SD_HOST_DRIVE disabled
+    #define SD_DETECT_PIN                   PC4   // Doesn't work when ONBOARD and NO_SD_HOST_DRIVE disabled
   #elif SD_CONNECTION_IS(LCD)
     #define ENABLE_SPI1
     #define SDSS                     EXP2_04_PIN

diff --git a/Marlin/src/pins/stm32f4/pins_MKS_ROBIN_NANO_V3_common.h b/Marlin/src/pins/stm32f4/pins_MKS_ROBIN_NANO_V3_common.h
@@ -212,7 +212,7 @@
 //
 // Onboard SD card
 //
-// detect pin doesn't work when ONBOARD and NO_SD_HOST_DRIVE disabled
+// Detect pin doesn't work when ONBOARD and NO_SD_HOST_DRIVE disabled
 #if SD_CONNECTION_IS(ONBOARD)
   #define ENABLE_SPI3
   #define SD_SS_PIN                         -1