M125 T : Maintenance PAUSE / Timeless PAUSE , LCD menus available for repairing and cleaning, resumed by menu. BEST than others pauses #24786
Conversation
studiodyne
force-pushed
the
maintenance_park_m125t
branch
3 times, most recently
from
471114e to
a5765e8
Compare
studiodyne
force-pushed
the
maintenance_park_m125t
branch
from
a5765e8 to
931eb0c
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
2 times, most recently
from
43e0584 to
6ad5711
Compare
| if (pause_print(retract, park_point, show_lcd, 0)) { | ||
| if (ENABLED(EXTENSIBLE_UI) || BOTH(EMERGENCY_PARSER, HOST_PROMPT_SUPPORT) || !sd_printing || show_lcd) { | ||
| wait_for_confirmation(false, 0); | ||
| resume_print(0, 0, -retract, 0); |
There was a problem hiding this comment.
if resume is inside this if scope (line 134) and if, for some reason, is not true (my case with reprap full discount lcd) you don't call resume_print and print (when using SD) will hang. This is what I fixed in my PR #24877
There was a problem hiding this comment.
Thks for the fix , my PR, didn't make modification of the noticed lines , my code makes a timeless pause just before. I will rebase it when your fix will be on the upstream. I have MKS 12864 screen and I don't have this bug.
There was a problem hiding this comment.
My cnf is emergency parser and no host prompt. And since reprap full discount is not EXTENSIBLE_UI and I was printing via SD then printer was not "waiting for confirmation" but more dangerous with no "resume_print" call it was stuck waiting to resume. Just moving resume out of scope it solve printer hanging
studiodyne
changed the title
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
from
52a9e5e to
7e60d15
Compare
studiodyne
force-pushed
the
maintenance_park_m125t
branch
from
552e552 to
8849dff
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
from
a7eacbc to
5200b36
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
from
a71a62c to
250fd60
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
from
40e1292 to
339773d
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
2 times, most recently
from
e90c213 to
4b9bb85
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
6 times, most recently
from
27df113 to
8d31429
Compare
In sd printing or not . Now , you can pause the machine , use lcd , to move carriage , extruders , axis , or do ALL you want to make maintenance , or to clean nozzle. Every body knows that cleaning nozzle need to move the carriage somewhere is possible to insert the tool in the nozzle , and we need to load , to load again , to load again while nozzle seems to be ' good to resume'
But this feature doesn't EXIST in marlin
Now , is made !
In comparaison :
M600 force unload , force reload , and purge is limited ' impossible to clean during a print ' + Locked screen
M125 locked screen
and others is the same
How to :
Click M125T , add it in ' custom menu' , or add it in the filament runout script ( M125Tx make a beep every x seconds , if you love beeps :smile)
The printer park and pause , lcd menus are available , You can unload , load , move , heat , purge , no limit of your wishes ! You can make maintenance , once finish , click on menu ' resume print'
AMAZING !
devs : Tested and functionnal , for me it's a starting point, hope everybody will upgrade this to be more smart, Need a renaming/cleaning/reviewing/cosmeticking , but code works fine !
Thks