Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes preflight-checks.py #21365

Closed

Conversation

ellensp
Copy link
Contributor

@ellensp ellensp commented Mar 17, 2021

Description

After #21361 preflight-checks.py no longer advises of what env's to use.

Function get_envs_for_boardents() in preflight-checks.py returns a list of environment names but without the needed prefix, this resulted in preflight-checks.py not listed available environments to use.
Function check_envs() updated to use osregex.

Benefits

Works as was intended.

Related Issues

issue #21363

@ellensp
Copy link
Contributor Author

ellensp commented Mar 17, 2021

well that didn't work... marking draft till I work out what went wrong.

@ellensp ellensp marked this pull request as draft March 17, 2021 11:36
@ellensp
Copy link
Contributor Author

ellensp commented Mar 17, 2021

@thinkyhead hopefully this fix doesn't break what you where trying to do with osregex... please check.

@ellensp ellensp marked this pull request as ready for review March 17, 2021 12:27
@ellensp ellensp changed the title Fixes regular expression join in preflight-checks.py Fixes preflight-checks.py Mar 17, 2021
@thisiskeithb
Copy link
Member

thisiskeithb commented Mar 17, 2021

This still fails on one of the beta boards/environments I'm testing (so I can't post details), but works for others.

It'd be better to revert #21361

Edit: @rhapsodyv has some ideas that'll remove the need for this board’s custom variant, so it might be a moot point.

@kad
Copy link
Contributor

kad commented Mar 17, 2021

It'd be better to revert #21361

I'd really suggest to revert.
Once you will be able to publish example lines of those undisclosed build targets, I volunteer to update script to handle those.
Or just open issue with proposed example of how line would look line with same faked values and assign to me, I'll do script update for those..

@ellensp
Copy link
Contributor Author

ellensp commented Mar 18, 2021

going with revert.

@ellensp ellensp closed this Mar 18, 2021
@thinkyhead
Copy link
Member

ended up going with fix. #21372

@ellensp ellensp deleted the bugfix-2.0.x-#21363 branch April 16, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants