-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes preflight-checks.py #21365
Fixes preflight-checks.py #21365
Conversation
well that didn't work... marking draft till I work out what went wrong. |
@thinkyhead hopefully this fix doesn't break what you where trying to do with osregex... please check. |
This still fails on one of the beta boards/environments I'm testing (so I can't post details), but works for others. It'd be better to revert #21361 Edit: @rhapsodyv has some ideas that'll remove the need for this board’s custom variant, so it might be a moot point. |
I'd really suggest to revert. |
going with revert. |
ended up going with fix. #21372 |
Description
After #21361 preflight-checks.py no longer advises of what env's to use.
Function get_envs_for_boardents() in preflight-checks.py returns a list of environment names but without the needed prefix, this resulted in preflight-checks.py not listed available environments to use.
Function check_envs() updated to use osregex.
Benefits
Works as was intended.
Related Issues
issue #21363