Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR 21361 broke preflight-checks.py, no env's listed #21363

Closed
ellensp opened this issue Mar 17, 2021 · 2 comments
Closed

PR 21361 broke preflight-checks.py, no env's listed #21363

ellensp opened this issue Mar 17, 2021 · 2 comments

Comments

@ellensp
Copy link
Contributor

ellensp commented Mar 17, 2021

Did you test the latest bugfix-2.0.x code?

Yes, and the problem still exists.

Bug Description

After #21361 preflight-checks.py no longer advises of what env's to use.

eg.
"Error: Build environment 'mega2560' is incompatible with BOARD_BTT_SKR_MINI_E3_V2_0. Use one of these:"

should say "Error: Build environment 'mega2560' is incompatible with BOARD_BTT_SKR_MINI_E3_V2_0. Use one of these: STM32F103RC_btt,STM32F103RC_btt_512K,STM32F103RC_btt_USB,STM32F103RC_btt_512K_USB"

Bug Timeline

8 hours ago

Expected behavior

A list of valid ENV's should be provided.

Actual behavior

No valid ENV's are provided.

Steps to Reproduce

  1. select a non ramps mottherboard eg BOARD_BTT_SKR_MINI_E3_V2_0.
  2. click build
  3. look at Build environment error. It does not contain list of valid env's

Version of Marlin Firmware

bugfix

@ellensp
Copy link
Contributor Author

ellensp commented Mar 18, 2021

going with revert instead #21372

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant