fix(cesium-draw): draw by primitive or geojson #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syncush
requested changes
Dec 12, 2020
Comment on lines
110
to
111
| default: | ||
| break; |
Comment on lines
65
to
107
| (drawHelper as any).startDrawingPolygon({ | ||
| callback: (positions: PrimitiveCoordinates) => { | ||
| //// MAKE polygon editable example | ||
| // var polygon = new DrawHelper.PolygonPrimitive({ | ||
| // positions: positions, | ||
| // width: 5, | ||
| // geodesic: true | ||
| // }); | ||
| // mapViewer.scene.primitives.add(polygon); | ||
| // polygon.setStrokeStyle(Color.AQUA,1); | ||
| // polygon.setEditable(); | ||
| // polygon.addListener('onEdited', function(event) { | ||
| // console.log('Polygone edited, ' + event.positions.length + ' points'); | ||
| // }); | ||
| drawState.handler({ | ||
| primitive: positions, | ||
| type: DrawType.POLYGON, | ||
| geojson: polygonToGeoJSON(positions as Cartesian3[]), | ||
| }); | ||
| }, | ||
| }); | ||
| break; | ||
| case DrawType.BOX: | ||
| // eslint-disable-next-line | ||
| (drawHelper as any).startDrawingExtent({ | ||
| callback: (positions: PrimitiveCoordinates) => { | ||
| //// MAKE box editable example | ||
| // var extentPrimitive = new DrawHelper.ExtentPrimitive({ | ||
| // extent: positions, | ||
| // material: Cesium.Material.fromType(Cesium.Material.StripeType) | ||
| // }); | ||
| // mapViewer.scene.primitives.add(extentPrimitive); | ||
| // extentPrimitive.setStrokeStyle(Color.AQUA,1); | ||
| // extentPrimitive.setEditable(); | ||
| // extentPrimitive.addListener('onEdited', function(event) { | ||
| // console.log('Extent edited: extent is (N: ' + event.extent.north.toFixed(3) + ', E: ' + event.extent.east.toFixed(3) + ', S: ' + event.extent.south.toFixed(3) + ', W: ' + event.extent.west.toFixed(3) + ')'); | ||
| // }); | ||
| drawState.handler({ | ||
| primitive: positions, | ||
| type: DrawType.BOX, | ||
| geojson: rectangleToGeoJSON(positions as Rectangle), | ||
| }); | ||
| }, |
There was a problem hiding this comment.
in each case you do (drawHelper as any) I would extract that code into a new casted variable
Comment on lines
+125
to
+130
| drawEntity.coordinates !== undefined | ||
| ? drawEntity.coordinates | ||
| : geoJSONToPrimitive( | ||
| drawEntity.type, | ||
| drawEntity.geojson as FeatureCollection | ||
| ); |
There was a problem hiding this comment.
why suppressing @typescript-eslint/no-unnecessary-condition ? is it an unnecessary condition?
There was a problem hiding this comment.
Local linting problems,
"Eagle eye", DONE
packages/react-components/src/lib/cesium-map/tools/draw/drawHelper.ts
Outdated
Show resolved
Hide resolved
asafMasa
requested changes
Dec 13, 2020
packages/react-components/src/lib/cesium-map/data-sources/drawings.data-source.stories.tsx
Show resolved
Hide resolved
packages/react-components/src/lib/cesium-map/data-sources/drawings.data-source.stories.tsx
Show resolved
Hide resolved
packages/react-components/src/lib/cesium-map/data-sources/drawings.data-source.stories.tsx
Show resolved
Hide resolved
packages/react-components/src/lib/cesium-map/tools/draw/drawHelper.ts
Outdated
Show resolved
Hide resolved
packages/react-components/src/lib/cesium-map/tools/geojson/geojson-to-primitive.ts
Show resolved
Hide resolved
asafMasa
approved these changes
Dec 13, 2020
Closed
acun87
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues:
MapColonies/discrete-layer-client#23
Checklist
What I did
More information: