Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support sub configuration to be immutable to #19

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

ronenkapelian
Copy link
Contributor

@ronenkapelian ronenkapelian commented Nov 26, 2024

implement deepFreeze method based on Object. freeze()

Question Answer
Bug fix
New feature
Breaking change
Deprecations
Documentation
Tests added
Chore

closes #18
Users can't modify the object, not the root, and not the children

Copy link

Hi it is me, your friendly bot helper! 👋
I've packed this commit for you 😊
You can install it like this:

{
  "dependencies": {
      "@map-colonies/config": "https://ghatmpstorage.blob.core.windows.net/npm-packages/config-9955338876c6cfbc248a98820a848414d2604bc2.tgz"
  }
}

The link will expire in a week ⌛

tests/config.spec.ts Outdated Show resolved Hide resolved
tests/config.spec.ts Outdated Show resolved Hide resolved
Copy link

Hi it is me, your friendly bot helper! 👋
I've packed this commit for you 😊
You can install it like this:

{
  "dependencies": {
      "@map-colonies/config": "https://ghatmpstorage.blob.core.windows.net/npm-packages/config-d55d9ae4f7c9594e9bc5b7fdceb5b49a65e4885e.tgz"
  }
}

The link will expire in a week ⌛

@ronenkapelian ronenkapelian linked an issue Nov 28, 2024 that may be closed by this pull request
@CptSchnitz CptSchnitz merged commit 7609fa3 into master Dec 5, 2024
5 checks passed
@CptSchnitz CptSchnitz deleted the freeze-config-object branch December 5, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deep objects can be modified by the user
3 participants