Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deep objects can be modified by the user #18

Closed
netanelC opened this issue Nov 24, 2024 · 0 comments · Fixed by #19
Closed

deep objects can be modified by the user #18

netanelC opened this issue Nov 24, 2024 · 0 comments · Fixed by #19
Assignees
@ronenkapelian
Labels
bug Something isn't working

Comments

@netanelC
Copy link
Contributor

netanelC commented Nov 24, 2024 •
edited
Loading

Users can modify the object if it is not the root object

To Reproduce
Add property to the root object - can't be done (as expected)
Add property to one of his children - can be done (should not)

Expected behavior
Users can't modify the object, not the root and not the children

You can see this source
@netanelC netanelC added the bug Something isn't working label Nov 24, 2024
@ronenkapelian ronenkapelian mentioned this issue Nov 26, 2024
Merged
@ronenkapelian ronenkapelian self-assigned this Nov 28, 2024
@ronenkapelian ronenkapelian linked a pull request Nov 28, 2024 that will close this issue
fix: support sub configuration to be immutable to #19
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ronenkapelian ronenkapelian

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support sub configuration to be immutable to MapColonies/config
2 participants
@netanelC @ronenkapelian