Port uvloop to Python 3.12 #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's deprecated in 3.0.3
This is a pre-requisite for supporting Cython 3.0, but makes sense to do for 0.29.* just as well.
|
While working on this I stumbled upon what seems to be an asyncio regression in 3.12. Good news that uvloop doesn't have this regression. Bad news -- our tests that test compliance with asyncio are now failing (we should backport our functional tests to the Python project, they increase test coverage by a lot!) |
Seems that we need to update to Cython 3
graingert
reviewed
Oct 8, 2023
1st1
force-pushed
the
12
branch
3 times, most recently
from
de6fd30
to
2783939
Compare
graingert
suggested changes
Oct 8, 2023
1st1
force-pushed
the
12
branch
5 times, most recently
from
69e3e54
to
e1c1e69
Compare
fantix
force-pushed
the
12
branch
2 times, most recently
from
dedf200
to
c479675
Compare
This partially reverts commit 247fb17.
fantix
approved these changes
Oct 9, 2023
|
Is there an ETA on a release? |
4 tasks
fantix
added a commit
that referenced
this pull request
Oct 12, 2023
Merged
fantix
added a commit
that referenced
this pull request
Oct 13, 2023
Changes ======= * Port uvloop to Python 3.12 (#570) (by @1st1, @fantix in 9f82bd7 for #569) * Upgrade libuv to v1.46.0 (#571) (by @fantix in 2e1978c for #571) Fixes ===== * CI fixes (#520, #553) (by @altendky in 7783f1c, @dulmandakh in 1dd40f1) * Make extract_stack resilient to lacking frames. (#563) (by @jhance in 0687643 for #563)
This was referenced Oct 15, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #569