Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update recipe for py312_patch #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update recipe for py312_patch #5

wants to merge 2 commits into from

Conversation

cbouss
Copy link

@cbouss cbouss commented Sep 28, 2023

Preparation for py312 release.

@anaconda-pkg-build
Copy link

Linter check found the following problems: The following problems have been found:

ERROR: clone/recipe/meta.yaml:18: pip_install_args: pip install should be run with --no-deps and --no-build-isolation.
ERROR: clone/recipe/meta.yaml:29: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
Errors were found

@cbouss cbouss closed this Oct 16, 2023
@cbouss cbouss reopened this Oct 16, 2023
@anaconda-pkg-build
Copy link

Linter check found the following problems: The following problems have been found:

ERROR: clone/recipe/meta.yaml:18: pip_install_args: pip install should be run with --no-deps and --no-build-isolation.
ERROR: clone/recipe/meta.yaml:29: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
Errors were found

@anaconda-pkg-build
Copy link

Linter check found the following problems: The following problems have been found:

ERROR: clone/recipe/meta.yaml:29: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
Errors were found

@cbouss cbouss closed this Oct 16, 2023
@cbouss cbouss reopened this Oct 16, 2023
@anaconda-pkg-build
Copy link

Linter check found the following problems: The following problems have been found:

ERROR: clone/recipe/meta.yaml:29: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
Errors were found

danpetry
danpetry requested changes Oct 17, 2023
View reviewed changes
Copy link

@danpetry danpetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like upstream doesn't have a release that supports python 3.12 yet. For example, this PR got merged only last week and this issue strongly suggests it's not compatible yet

recipe/meta.yaml
script:
- {{ PYTHON }} -m pip install . -vv --no-deps --global-option='build_ext' --global-option='--cython-always' --global-option='--use-system-libuv'
- {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation --global-option='build_ext' --global-option='--cython-always' --global-option='--use-system-libuv'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--ignore-installed and --no-cache-dir?

recipe/meta.yaml
@@ -24,7 +24,7 @@ requirements:
- patch # [unix]
host:
- python
- cython 0.29.32
- cython 0.29
- pip
- libuv
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should libuv be pinned?

recipe/meta.yaml
@@ -24,7 +24,7 @@ requirements:
- patch # [unix]
host:
- python
- cython 0.29.32
- cython 0.29
- pip
- libuv
- setuptools
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

including the test suite could be nice since it's compiled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danpetry danpetry danpetry requested changes

@skupr-anaconda skupr-anaconda skupr-anaconda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cbouss @anaconda-pkg-build @danpetry @skupr-anaconda