Feature/indoor humidity #1025
Feature/indoor humidity #1025
Conversation
* 'develop' of github.com:ryck/MagicMirror: Add template for v2.1.3 Set dev version.
…a INDOOR_HUMIDITY notification
* upstream/develop: (71 commits) Update sample address set version of express-ipfilter: Describe default in comment of sample config More secure defaults. Fix grunt errors Weather forecast settings match current weather Fix JavaScript error in weatherforecast Update fr.json TestSuite: Show the missing strings for translations files. Update fr.json with added translations Added e2e test for font files Fix issue MagicMirrorOrg#986 Fix extra tab file translations/zh_cn.json Add Changelog entry for new e2e test for helloworld module Small change for re-running Travis CI Change Two Conditionals to UpperCase-If Fix linting? Show Scale of Temperature if config flag is set Change to install Roboto fonts by npm Update stylelint package ...
* develop: (71 commits) Update sample address set version of express-ipfilter: Describe default in comment of sample config More secure defaults. Fix grunt errors Weather forecast settings match current weather Fix JavaScript error in weatherforecast Update fr.json TestSuite: Show the missing strings for translations files. Update fr.json with added translations Added e2e test for font files Fix issue MagicMirrorOrg#986 Fix extra tab file translations/zh_cn.json Add Changelog entry for new e2e test for helloworld module Small change for re-running Travis CI Change Two Conditionals to UpperCase-If Fix linting? Show Scale of Temperature if config flag is set Change to install Roboto fonts by npm Update stylelint package ... # Conflicts: # CHANGELOG.md
|
@ryck Just curious, I'm having a little bit of trouble determining where the data for this comes from. Are you getting it from OpenWeatherMap? (we're having a bit of trouble with specific endpoints, so I'm trying to figure out some changes) |
|
Hi @nhubbard It's coming from a DHT22 sensor, using this module: https://github.com/ryck/MMM-DHT-Sensor; it's the indoor humidity after all 😛 |
|
@nhubbard Whatever you think is best, I just did the PR under the impression this was similar to the INDOOR_TEMPERATURE (ie, have support for the notification, no matter where it comes). IMHO, there is no point in merge anything else: either we want the currentwheather to support it or not (which is also fine, maybe having the ext temperature, int temperature and int humidity is a little too much) |
|
I like this contribution, especially since the source can be determined by an external module. |
Note: Sometimes the development moves very fast. It is highly
recommended that you update your branch of
developbefore creating apull request to send us your changes. This makes everyone's lives
easier (including yours) and helps us out on the development team.
Thanks!