Change to install Roboto fonts by npm #986
Conversation
roramirez
force-pushed
the
roboto-fonts-as-vendor
branch
from
f7a845e to
aed09f0
Compare
|
If I do a fresh install of MagicMirror (and Example from roboto.css : Actual filename is : I just wanted to verify that others can reproduce this issue as well before I proposed a fix for this... @roramirez Can you confirm that your fonts do not get loaded as well? |
|
@QNimbus You're right! My mistake :( There a way to make a test for the css? |
Fixed some font file paths
Fixed some font file paths
|
@roramirez I've made an attempt at an e2e test case and added it to the PR #986. I think I inadvertently also found the reason why the vendor_spec.js test case isn't working at this moment (hit and miss) and I will try to test my theory; if it works I will submit a PR for that as well... |
|
I stay expectant :O, Do you mean this? |
* upstream/develop: (71 commits) Update sample address set version of express-ipfilter: Describe default in comment of sample config More secure defaults. Fix grunt errors Weather forecast settings match current weather Fix JavaScript error in weatherforecast Update fr.json TestSuite: Show the missing strings for translations files. Update fr.json with added translations Added e2e test for font files Fix issue MagicMirrorOrg#986 Fix extra tab file translations/zh_cn.json Add Changelog entry for new e2e test for helloworld module Small change for re-running Travis CI Change Two Conditionals to UpperCase-If Fix linting? Show Scale of Temperature if config flag is set Change to install Roboto fonts by npm Update stylelint package ...
* develop: (71 commits) Update sample address set version of express-ipfilter: Describe default in comment of sample config More secure defaults. Fix grunt errors Weather forecast settings match current weather Fix JavaScript error in weatherforecast Update fr.json TestSuite: Show the missing strings for translations files. Update fr.json with added translations Added e2e test for font files Fix issue MagicMirrorOrg#986 Fix extra tab file translations/zh_cn.json Add Changelog entry for new e2e test for helloworld module Small change for re-running Travis CI Change Two Conditionals to UpperCase-If Fix linting? Show Scale of Temperature if config flag is set Change to install Roboto fonts by npm Update stylelint package ... # Conflicts: # CHANGELOG.md
Remove the Roboto fonts into source code or project. These are install by npm.