Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc fixes for joss review #95

Merged
merged 23 commits into from
Oct 30, 2023
Merged
Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
c94b9ea
specify path for jupyter log
MaceKuailv Oct 30, 2023
a44c8cd
found a way to raise all warnings in jupyter book as exit code 1
MaceKuailv Oct 30, 2023
2085d9c
let's see if the CI can capture that
MaceKuailv Oct 30, 2023
4fdf422
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 30, 2023
ed9d6a5
fix check_readiness docstring
MaceKuailv Oct 30, 2023
66839f8
fix hidden stuff in _config
MaceKuailv Oct 30, 2023
0f63218
fix a warning from sphinx theme
MaceKuailv Oct 30, 2023
57405ca
try another place to put the navigation-key thing
MaceKuailv Oct 30, 2023
bce0ab5
explain the dependencies
MaceKuailv Oct 30, 2023
5aaa772
conda install is available
MaceKuailv Oct 30, 2023
5a5ccc6
add instruction on rep iss
MaceKuailv Oct 30, 2023
aaa6c29
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 30, 2023
d999556
improve optional dependency, after clarified
MaceKuailv Oct 30, 2023
9eb2697
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 30, 2023
363b247
hide non-public in 3 files
MaceKuailv Oct 30, 2023
5c10d1b
renaming fixed
MaceKuailv Oct 30, 2023
87e9dd7
rename knw and eulerian
MaceKuailv Oct 30, 2023
120faae
toc fix and style
MaceKuailv Oct 30, 2023
5839f01
renamed file forgot to include
MaceKuailv Oct 30, 2023
87d835e
Merge branch 'joss1' of github.com:MaceKuailv/seaduck into joss1#
MaceKuailv Oct 30, 2023
b081058
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 30, 2023
2b8b0dd
fix missing link
MaceKuailv Oct 30, 2023
0fe1fa1
Merge branch 'joss1' of github.com:MaceKuailv/seaduck into joss1
MaceKuailv Oct 30, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ conda-env-update:
$(CONDA) env update $(CONDAFLAGS) -f environment.yml

docs-build:
jupyter-book build docs/
jupyter-book build docs/ -W --keep-going

joss:
pandoc paper/paper.md --bibliography paper/paper.bib -o paper/paper_local.pdf
10 changes: 4 additions & 6 deletions docs/_config.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Book settings
# Learn more at https://jupyterbook.org/customize/config.html

title: My sample book
author: The Jupyter Book Community
title: Seaduck Tutorial
author: Wenrui Jiang
logo: logo.png

# Force re-execution of notebooks on each build.
Expand All @@ -27,15 +27,13 @@ sphinx:
config:
html_theme: sphinx_book_theme
autodoc_member_order: groupwise
html_theme_options:
navigation_with_keys: false
# html_theme_options: {
# "relbarbgcolor": 'Orange',
# "codebgcolor": 'Coral'
# }

# Add a bibtex file so that we can create citations
bibtex_bibfiles:
- references.bib

# Information about where the book exists on the web
repository:
url: https://github.com/MaceKuailv/seaduck # Online location of your book
Expand Down
1 change: 1 addition & 0 deletions docs/_toc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,5 @@ parts:
- file: contribute/prep_env
- file: contribute/contr_cod
- file: contribute/contr_doc
- file: contribute/report_iss
- file: contribute/tidyNpr
16 changes: 16 additions & 0 deletions docs/contribute/report_iss.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Report Issues on GitHub

Aside from contributing to code and documentation, another good way to help the package is to report issues. An Issue could be about a feature request, a bug report, or any of your cool suggestions.

We use GitHub to keep track of the issues. To see a list of all past issues, simply go to [this page](https://github.com/MaceKuailv/seaduck/issues).

Before you report a new issue, make sure you follow these two simple steps:

1. Read through relevant sections in the documentation;
1. Use the search bar to see if the issue has already been reported.

If both didn't help, you can go ahead and click the big green button that says "New Issue". Writing the issue should be very straightforward. Make sure that the message is clear to other people reading this issue. One of the best ways of doing that is to give a [minimum reproducible example](https://en.wikipedia.org/wiki/Minimal_reproducible_example).

Please remember that the purpose of this GitHub issues channel is to improve the package and that the developers of `seaduck` have their day-time jobs. We are not going to provide direct instruction on how to use this package or python.

That said, never feel intimidated to ask questions that you think is dumb. By reporting an issue, you also help others who are in the same situation. If you spend enough effort working on the problem and still cannot figure it out, there must be something confusing or wrong about the code or the documentation. We will really appreciate it if you point that out.
26 changes: 19 additions & 7 deletions docs/how_to_install.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,35 @@ The package can be installed simply by
pip install seaduck
```

or, alternatively (not available yet)
or, alternatively

```shell
conda install -c conda-forge seaduck
```

or, alternatively (for latest code development), see [a guide for new contibutors](guide_for_developer.md).

## Optional dependencies

- numba

- Compile and make everything faster!

- matplotlib

- Plot the shape of interpolation kernel.

- pandas

- Show variable aliasing in an intuitive way.

- pooch, zarr, cartopy

- Needed for running the tutorial examples.

## Required dependencies

- python
- numpy
- xarray

## Optional dependencies

- pandas
- numba
- matplotlib
- dask
21 changes: 2 additions & 19 deletions docs/idealize_test/tilted_stream.ipynb
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"cells": [
{
"attachments": {},
"cell_type": "markdown",
"metadata": {},
"source": [
Expand Down Expand Up @@ -42,7 +41,6 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"metadata": {},
"source": [
Expand Down Expand Up @@ -84,7 +82,6 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"metadata": {},
"source": [
Expand Down Expand Up @@ -123,7 +120,6 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"metadata": {},
"source": [
Expand All @@ -143,7 +139,6 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"metadata": {},
"source": [
Expand Down Expand Up @@ -177,7 +172,6 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"metadata": {},
"source": [
Expand Down Expand Up @@ -216,7 +210,6 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"metadata": {},
"source": [
Expand All @@ -235,7 +228,6 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"metadata": {},
"source": [
Expand Down Expand Up @@ -273,7 +265,6 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"metadata": {},
"source": [
Expand Down Expand Up @@ -325,7 +316,6 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"metadata": {},
"source": [
Expand Down Expand Up @@ -354,7 +344,6 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"metadata": {
"tags": [
Expand Down Expand Up @@ -387,7 +376,6 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"metadata": {
"tags": [
Expand All @@ -399,7 +387,6 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"metadata": {},
"source": [
Expand Down Expand Up @@ -428,7 +415,6 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"metadata": {},
"source": [
Expand Down Expand Up @@ -457,7 +443,6 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"metadata": {},
"source": [
Expand All @@ -467,7 +452,6 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"metadata": {},
"source": [
Expand All @@ -484,11 +468,10 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"metadata": {},
"source": [
"Bu these are pretty small errors!"
"But these are pretty small errors!"
]
}
],
Expand All @@ -509,7 +492,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.11.4"
"version": "3.9.7"
}
},
"nbformat": 4,
Expand Down
Loading