-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc fixes for joss review #95
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
- Coverage 94.84% 94.28% -0.57%
==========================================
Files 11 11
Lines 2658 2658
Branches 712 712
==========================================
- Hits 2521 2506 -15
- Misses 50 66 +16
+ Partials 87 86 -1
☔ View full report in Codecov by Sentry. |
This test failed because I added
in one of the notebooks. and jupyter book is able to capture that. This is to test #92 and it seems to be working. |
for more information, see https://pre-commit.ci
Just added a new file on how to use the github issue channel properly. This should address issue #93 |
for more information, see https://pre-commit.ci
@pnsaevik Thank you very much for your suggestions. Please let me know if this PR addresses some of the problems and if I understand you correctly. I will merge this branch if you think at least some of the issue is resolved. Please feel welcomed to raise other issues or continue the discussion in existing ones. I really appreciate your comments. |
because of freaking style change Please enter a commit message to explain why this merge is necessary,
for more information, see https://pre-commit.ci
That's very encouraging! I actually plan to do that as well. The only problem is that I don't have a ROMS dataset at hand. I think it should be easy (fingers crossed) because I always have that in mind and kept the grid handling pretty modular. |
I am going to group the first patch of fixes (mainly on documentations) in this PR.