This repository has been archived by the owner on Feb 15, 2023. It is now read-only.
Fixes for latest commit of scipy and add universal2 wheels #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes ported from `numpy-wheels` found at: - MacPython/numpy-wheels#104 - MacPython/numpy-wheels#115
Ported from: - MacPython/numpy-wheels#109 - MacPython/numpy-wheels#110
|
This is finally ready for a review @rgommers. |
rgommers
reviewed
Aug 23, 2021
| if [ -z "$IS_OSX" ]; then | ||
| unset FFLAGS | ||
| export LDFLAGS="-shared -Wl,-strip-all" |
There was a problem hiding this comment.
Just checking: this can be removed because it's done as a post-processing step by multibuild (https://github.com/matthew-brett/multibuild/blob/cdffc52846355707f389808414cf8dfe31289328/configure_build.sh#L44)? I'm not quite sure why in that code macOS is special-cased and doesn't have STRIP_FLAGS.
There was a problem hiding this comment.
Previously, because of numpy's LDFLAGS behaviour (overwriting instead of appending), this was needed, but not anymore.
-shared is not needed anymore due to that and strip flags are set by multibuild anyway.
rgommers
approved these changes
Aug 23, 2021
There was a problem hiding this comment.
Looks great, let's give this a go! Thanks @isuruf and @judahrand!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @judahrand
Wait for
universal2 support was added in scipy/scipy#14316