This repository has been archived by the owner on Feb 15, 2023. It is now read-only.
Enable universal2 wheels #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes ported from `numpy-wheels` found at: - MacPython/numpy-wheels#104 - MacPython/numpy-wheels#115
isuruf
reviewed
Jun 28, 2021
|
You also need MacPython/numpy-wheels#109 and MacPython/numpy-wheels#110 |
Should be included now, thanks very much for pointing those out. |
|
I believe the PR I opened on |
isuruf
reviewed
Aug 20, 2021
Comment on lines
+19
to
+39
| # TODO: Remove once https://github.com/matthew-brett/multibuild/pull/409 lands | ||
| function pyinst_fname_for_version { | ||
| # echo filename for OSX installer file given Python and minimum | ||
| # macOS versions | ||
| # Parameters | ||
| # $py_version (Python version in major.minor.extra format) | ||
| # $py_osx_ver: {major.minor | not defined} | ||
| # if defined, the minimum macOS SDK version that Python is | ||
| # built for, eg: "10.6" or "10.9", if not defined, infers | ||
| # this from $py_version using macpython_sdk_for_version | ||
| local py_version=$1 | ||
| local py_osx_ver=${2:-$(macpython_sdk_for_version $py_version)} | ||
| local inst_ext=$(pyinst_ext_for_version $py_version) | ||
| echo "python-${py_version}-macosx${py_osx_ver}.${inst_ext}" | ||
| } | ||
|
|
||
| function install_delocate { | ||
| check_pip | ||
| $PIP_CMD install git+https://github.com/isuruf/delocate.git@arm64 | ||
| } | ||
|
|
There was a problem hiding this comment.
If you update multibuild, this can be removed.
|
Something is still wrong, on TravisCI: It should be |
|
Appveyor is also unhappy: |
|
I'll try to have a look at this this evening |
|
Continued in gh-125, closing this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes ported from
numpy-wheelsfound at: