feat(Company): make editable company name #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaspard-lonchampt
force-pushed
the
feat/make-companyName-editable-for-manager
branch
from
417670a
to
82cd32f
Compare
tristan-gueguen
requested changes
Sep 18, 2023
There was a problem hiding this comment.
🟠 Est-ce que le composant que tu as créé EditableText ne pourrait pas être utlisé à d'autres endroits ?
🟢 Si j'édite le nom, que je ne change rien (ou que je remets le même), la requête part quand même si je valide (on pourrait économiser une requête en ne le faisant pas)
🔴 J'ai fait exprès pour voir mais j'ai mis un texte de plus de 255 caractères comme nouveau nom et ça a fait une erreur serveur et un décalage entre le serveur et le front. Peut-être qu'on peut mettre une limitation dans le nombre de caractères autorisés ?
gaspard-lonchampt
force-pushed
the
feat/make-companyName-editable-for-manager
branch
from
82cd32f
to
1081ce3
Compare
tristan-gueguen
approved these changes
Sep 19, 2023
gaspard-lonchampt
force-pushed
the
feat/make-companyName-editable-for-manager
branch
from
1081ce3
to
3f9ea50
Compare
- Add api request for company name ; - Add reducer for company name to change value in store ; - Add generic component for editable text field ; - Add string lenght validation ;
gaspard-lonchampt
force-pushed
the
feat/make-companyName-editable-for-manager
branch
from
3f9ea50
to
5723506
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
gaspard-lonchampt
deleted the
feat/make-companyName-editable-for-manager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/z4LXmpsp/1210-permettre-aux-gestionnaires-de-modifier-le-nom-de-leurs-entreprises
Dépendance
PR: MTES-MCT/mobilic-api#272