feat(Company): make company name editable #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristan-gueguen
approved these changes
Sep 18, 2023
| @@ -316,5 +319,3 @@ class PrivateQueries( | |||
| protected_graphql_schema = graphene.Schema( | |||
| query=ProtectedQueries, mutation=ProtectedMutations | |||
| ) | |||
|
|
|||
| from app.controllers.contacts import * | |||
There was a problem hiding this comment.
🟢 est-ce que tu as une idée de pourquoi cette ligne était tout en bas ?
There was a problem hiding this comment.
ça j'ai remarqué que c'était mes extensions Python sur vscode qui rajoutait cela quand je sauvegardais, depuis je les ai désactivé mais cette ligne est passé à la trappe !
app/controllers/company.py
Outdated
| get_target_from_args=lambda cls, _, info, **kwargs: Company.query.get( | ||
| kwargs["company_id"] | ||
| ), | ||
| error_message="You need to be a company admin to be able to edit company settings", |
There was a problem hiding this comment.
🟢 company settings -> company name
- Add UpdateCompanyName class to handle company name update;
gaspard-lonchampt
force-pushed
the
feat/make-companyName-editable-for-manager
branch
from
df1671f
to
2cc6d44
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
gaspard-lonchampt
deleted the
feat/make-companyName-editable-for-manager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/z4LXmpsp/1210-permettre-aux-gestionnaires-de-modifier-le-nom-de-leurs-entreprises
Dépendance
PR: MTES-MCT/mobilic#409