Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gdt 116 update locations #113

Merged
merged 5 commits into from
Jan 22, 2024
Merged

Gdt 116 update locations #113

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
575bae4
Add dct_spatial_sm to get_subjects
ehanson8 Jan 10, 2024
9e8a516
Update record_is_deleted method
ehanson8 Jan 10, 2024
9dde779
Update Location class to use WKT strings
ehanson8 Jan 11, 2024
0229375
Updates dependencies
ehanson8 Jan 11, 2024
6aa4df8
Updates based on discussion in PR #113
ehanson8 Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/sources/json/test_aardvark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ def test_aardvark_get_subjects_success(aardvark_record_all_fields):
assert MITAardvark.get_subjects(next(aardvark_record_all_fields)) == [
timdex.Subject(value=["Country"], kind="DCAT Keyword"),
timdex.Subject(value=["Political boundaries"], kind="DCAT Theme"),
timdex.Subject(value=["Some city, Some country"], kind="Dublin Core Spatial"),
ehanson8 marked this conversation as resolved.
Show resolved Hide resolved
timdex.Subject(value=["Geography"], kind="Dublin Core Subject"),
timdex.Subject(value=["Earth"], kind="Dublin Core Subject"),
timdex.Subject(value=["Dataset"], kind="Subject scheme not provided"),
Expand Down
1 change: 1 addition & 0 deletions transmogrifier/sources/json/aardvark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,7 @@ def get_subjects(source_record: dict) -> list[timdex.Subject]:
aardvark_subject_fields = {
"dcat_keyword_sm": "DCAT Keyword",
"dcat_theme_sm": "DCAT Theme",
"dct_spatial_sm": "Dublin Core Spatial",
"dct_subject_sm": "Dublin Core Subject",
"gbl_resourceClass_sm": "Subject scheme not provided",
"gbl_resourceType_sm": "Subject scheme not provided",
Expand Down