Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gdt 116 update locations #113

Merged
merged 5 commits into from
Jan 22, 2024
Merged

Gdt 116 update locations #113

merged 5 commits into from
Jan 22, 2024

Commits on Jan 11, 2024

  1. Configuration menu
    Copy the full SHA
    575bae4 View commit details
    Browse the repository at this point in the history
  2. Update record_is_deleted method

    * Add functionality to record_is_deleted method as well as corresponding unit tests to reflect possible data scenarios
    * Add unit tests for write_output_files method now that deleted records are properly processed
    * Update aardvark_records fixtures to include deleted records
    ehanson8 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    9e8a516 View commit details
    Browse the repository at this point in the history
  3. Update Location class to use WKT strings

    Why these changes are being introduced:
    * OpenSearch can parse the WKT strings that are found in MITAardvark records so the values don't require the previously expected parsing.
    
    How this addresses that need:
    * Rename Location.geodata attribute to geoshape as well as update corresponding unit tests and fixtures
    * Refactor get_locations method to store WKT strings as well as update corresponding unit tests and fixtures
    * Remove parse_geodata_string from helpers.py and corresponding unit tests
    * Add default kind value to get_identifiers method
    
    Side effects of this change:
    * None
    
    Relevant ticket(s):
    * https://mitlibraries.atlassian.net/browse/GDT-116
    ehanson8 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    9dde779 View commit details
    Browse the repository at this point in the history
  4. Updates dependencies

    ehanson8 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    0229375 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Updates based on discussion in PR #113

    * Update aardvark fixtures
    * Refactor record_is_deleted method and update corresponding unit test
    * Update kind values for get_subjects method
    ehanson8 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    6aa4df8 View commit details
    Browse the repository at this point in the history