Adds widget area to 404 template #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
matt-bernhardt
force-pushed
the
widgetized-404
branch
from
8972c30
to
89b5e0c
Compare
matt-bernhardt
force-pushed
the
widgetized-404
branch
from
89b5e0c
to
d2bd5c4
Compare
matt-bernhardt
force-pushed
the
widgetized-404
branch
2 times, most recently
from
0199ac7
to
a4e5e35
Compare
matt-bernhardt
force-pushed
the
widgetized-404
branch
from
a4e5e35
to
6de966d
Compare
matt-bernhardt
force-pushed
the
widgetized-404
branch
from
6de966d
to
a65fcda
Compare
JPrevost
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Use labels (
review needed,in progress, orpaused) to declare statusWhat does this PR do?
This creates a new widget area,
Migrated Content Notice, which is loaded on the 404 template to allow site builders to create custom notices about migrated content.Helpful background context (if appropriate)
This feature is intended to be used as part of a new website for Distinctive Collections, which involves the retirement or migration of almost 2000 pieces of content. Because it will not be possible to create redirects for each piece of retired or migrated content - thus guaranteeing that some traffic will make its way to the theme's 404 template - we are enabling the creation of content advisories at that step in the process.
How can a reviewer manually see the effects of these changes?
This branch has been deployed to the staging server, and a sample advisory created for the
/foo*path. The content we anticipate being used for the new DC site is at/test-404Screenshots:
Current 404 page:
New default 404 page (seen when no widgets are defined - phrasing changes slightly)
New custom 404 page (content now provided by a widget for a specified URL pattern, replacing the default)
Todo:
Requires new or updated plugins, themes, or libraries?
NO
Requires change to deploy process?
NO