Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: False alarm for hidden input fields #32

Closed
VincentTam opened this issue Aug 17, 2019 · 3 comments
Closed

BUG: False alarm for hidden input fields #32

VincentTam opened this issue Aug 17, 2019 · 3 comments

Comments

@VincentTam
Copy link

VincentTam commented Aug 17, 2019

Background

Hi, this is the maintainer of @staticmanlab, a public GitLab instance for Staticman. I've recently created PR pacollins/hugo-future-imperfect-slim#69 to introduced a new feature to the project (nested Staticman comments).

Problem

The setup of Staticman with reCAPTCHA for a static blog (theme) requires some hidden form fields.

<input hidden name="options[reCaptcha][siteKey]" value="{{ .sitekey }}">
<input hidden name="options[reCaptcha][secret]" value="{{ .encryptedkey }}">
<div class="g-recaptcha" data-sitekey="{{ .sitekey }}"></div>

Despite their invisibility in the rendered page, AccessLint has raised a false alarm for "missing label".

Screenshot from 2019-08-17 14-24-56

Expected behavior

No false alarm for hidden fields.

Remarks

Thanks for your great project. It spotted out a missing image alt in my image tags for Gravatar.

@VincentTam VincentTam changed the title BUG: kFalse alarm for hidden input fields BUG: False alarm for hidden input fields Aug 17, 2019
@matt-bernhardt
Copy link

I've also seen this issue, and have been looking for a place to report the behavior. Specifically, on this change:

MITLibraries/MITlibraries-parent#287

There are "violations" being reported for missing labels on both hidden fields and buttons - neither of which to my understanding require label elements.

WebAIM discusses buttons here:
https://webaim.org/techniques/forms/controls#button

Mozilla Developer Network also discusses this here:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label#Interactive_content

@stonebuzz
Copy link

is the same for me
image

How to prevent this ?

@ckundo
Copy link
Member

ckundo commented Feb 2, 2020

Resolved. Thanks y'all for the reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants